Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: regression when opening a new File #321

Merged
merged 3 commits into from
Feb 17, 2023

Conversation

AdarshdeepCheema
Copy link
Contributor

@AdarshdeepCheema AdarshdeepCheema commented Feb 16, 2023

This regression was caused by https://github.com/zowe/zlux-editor/pull/285/files#diff-168aee0d0ff778647f681a145fb1ce371d7f68f2ca9a30f014aa3f3efc214a56
For new files the path did not exist and the exception was thrown. Now it is fixed

Proposed changes

This PR addresses Issue: [Link to Github issue within https://github.com/zowe/zlux/issues if any]

This PR depends upon the following PRs:

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Change in a documentation
  • Refactor the code
  • Chore, repository cleanup, updates the dependencies.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

PR Checklist

Please delete options that are not relevant.

  • If the changes in this PR are meant for the next release / mainline, this PR targets the "staging" branch.
  • My code follows the style guidelines of this project (see: Contributing guideline)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes
  • video or image is included if visual changes are made
  • Relevant update to CHANGELOG.md
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works, or describe a test method below

Testing

Further comments

Signed-off-by: Adarshdeep Cheema <[email protected]>
@AdarshdeepCheema AdarshdeepCheema changed the title Fix open new file regression Fix: regression when opening a new File Feb 16, 2023
Copy link
Member

@DivergentEuropeans DivergentEuropeans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MVS and USS file tab handling appears to work well, in combo with hotkeys, closing, saving, and diff checking so approving and merging thanks Adarsh

@DivergentEuropeans DivergentEuropeans merged commit c553292 into v2.x/staging Feb 17, 2023
@AdarshdeepCheema AdarshdeepCheema deleted the fixOpenNewFileRegression branch February 17, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants