Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using config manager to create component list instead of 'zwe' #117

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

Gautham-coder
Copy link
Contributor

@Gautham-coder Gautham-coder commented Jun 12, 2024

Using configmgr to read config yaml for enabled components and check for start script in /instance/component-name/manifest, if both are present then add to component list, instead of zwe.

Solution:

  1. Check for enabled components
  2. for each enabled component check if the manifest.yaml exits either in <zowe.runtimeDirectory>/ components // or <zowe.extensionDirectory> /
  3. if it exists then read item 'commands.start', if present then add the component to the component list.

Relates to issue: #110

…for start script in /instance/component-name/manifest, if both are present then add to component list, instead of zwe

Signed-off-by: Gautham Kuppuswamy <[email protected]>
@Martin-Zeithaml Martin-Zeithaml added the enhancement New feature or request label Jun 13, 2024
@1000TurquoisePogs
Copy link
Member

So far in my testing this is working for me.

Copy link
Member

@1000TurquoisePogs 1000TurquoisePogs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a previous question about if setting BPX AUTOCVT was going to help other code.

I added an env printout in zowe-common-c/libs/common.js which seems to be the earliest possible execution of configmg+zwe code.

It prints out like so

2024-06-18 11:14:56.421 <ZWELNCH:17237194> USER INFO ZWEL0069I Configuration is valid                                                               
2024-06-18 11:14:56.421 <ZWELNCH:17237194> USER INFO ZWEL0058I WORKSPACE_DIR is '/me/inst/stc/workspace-stc-initinstance7'                
e is _BPXK_AUTOCVT=ON                                                                                                                                  
e is JAVA_DUMP_TDUMP_PATTERN=SVCDUMP.D%y%m%d.T%H%M%S.&SYSNAME..%job                                                                                    
e is _CEE_DMPTARG=/proj/dumps                                                                                                                          
e is ROOT_DIR=/mydir                                                                                                         
e is _CEE_RUNOPTS=HEAPPOOLS(OFF) ENVAR("_CEE_ENVFILE=DD:STDENV") POS(ON)                                                                               
e is _=/mydir/bin/utils/configmgr                                                                                             
e is ZLDEBUG=OFF                                                                                                                                       
e is CONFIG=FILE(/me/inst/stc/zowe.yaml)                                                                                                     
e is ZWE_zowe_runtimeDirectory=/mydir                                                                                        
e is ZWE_CLI_PARAMETER_CONFIG=FILE(/me/inst/stc/zowe.yaml)                                                                                   
e is WORKSPACE_DIR=/me/inst/stc/workspace-stc-initinstance7                                                                                  
e is TZ=EST5EDT                                                                                                                                        
e is ZWE_CLI_PARAMETER_HA_INSTANCE={{ha_instance_id}}                                                                                                  
e is _CEE_ENVFILE=DD:STDENV                                                                                                                            
2024-06-18 11:14:56 <ZWELS:17237742> USER INFO (zwe-internal-start-prepare) Zowe version: v2.16.0      

Point is, yes looks like it does get set by launcher properly, as almost nothing else is set at this time except things the launcher set.

@JoeNemo JoeNemo merged commit efd3c66 into v2.x/staging Jun 19, 2024
5 checks passed
1000TurquoisePogs added a commit that referenced this pull request Jul 5, 2024
…r checking component enabled status

Signed-off-by: 1000TurquoisePogs <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants