Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace "zwe internal get-launch-components" with configmgr call #110

Closed
1000TurquoisePogs opened this issue Apr 25, 2024 · 1 comment
Closed

Replace "zwe internal get-launch-components" with configmgr call #110

1000TurquoisePogs opened this issue Apr 25, 2024 · 1 comment

Comments

@1000TurquoisePogs
Copy link
Member

The launcher spins up zwe in a shell which in turn runs configmgr to do validation of the YAML all before just returning a list of which components have "enabled: true" in the YAML.

The launcher already has configmgr logic within. It does not need to consult zwe for this.
Change "get_component_list" https://github.com/zowe/launcher/blob/v2.x/staging/src/main.c#L1754 to just use cfg functions to read which components.[component-name].enabled values are true, instead of spawning a program to figure that out as we do today.
@Gautham-coder Gautham-coder mentioned this issue Jun 12, 2024
Merged
@1000TurquoisePogs
Copy link
Member Author

Completed for v2.17.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
zOS Squad Board
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@1000TurquoisePogs