Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return a token from auth._refreshBearerToken #149

Merged
merged 1 commit into from
Nov 25, 2021

Conversation

eatyourgreens
Copy link
Contributor

@eatyourgreens eatyourgreens commented Nov 25, 2021

Return the refreshed token, or an empty string, from auth._refreshBearerToken(). This should fix token-handling for code that expects auth.checkBearerToken() to return a valid token.

Return the refreshed token, or an empty string, from `auth._refreshBearerToken()`. This should fix token-handling for code that expects `auth.checkBearerToken()` to return a valid token.
Copy link
Contributor

@camallen camallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code changes LGTM.

OOI - did you run this locally in FEM app for testing?

For release - I assume this is a bug fix / patch version bump as we haven't changed the API of this client library function. I can't see this causing issues in PFE land but i'm not sure about other apps (do they use oauth?)... should we consider a major release and opt in?

@eatyourgreens
Copy link
Contributor Author

I haven't run this with the new classifier yet. I'll have a look. Maybe I can hack the dev classifier so that it always refreshes the token when it makes a classification.

@eatyourgreens
Copy link
Contributor Author

I think 3.3.4 should be ok for release. Anything that's checking the return value of auth.checkBearerToken() expects a falsy value to indicate that you aren't logged in.

@eatyourgreens
Copy link
Contributor Author

Setting up the monorepo's dev classifier to use this client turned out to be more work than I thought, but I've confirmed that it works with the changes here.

@eatyourgreens
Copy link
Contributor Author

eatyourgreens commented Nov 30, 2021

Fixes #148.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants