auth.checkBearerToken() returns undefined after refreshing a token

[eatyourgreens]

auth.checkBearerToken() returns undefined after refreshing a token, but it should return the refreshed token. The refreshed token is correctly set in the client, so subsequent calls do work.

// check an expired token. This should set token to the refreshed token but actually returns undefined.
let token = await auth.checkBearerToken()
// token is now refreshed. This sets it correctly.
token = await auth.checkBearerToken()

The underlying cause is that _refreshBearerToken returns undefined. It should return a Promise that resolves to the refreshed token.

panoptes-javascript-client/lib/auth.js

Lines 64 to 91 in 9438015

	_refreshBearerToken: function() {
	if (this._tokenRefreshPromise === null) {
	console.log('Refreshing expired bearer token');
	var url = config.host + '/oauth/token';
	var data = {
	grant_type: 'refresh_token',
	refresh_token: this._refreshToken,
	client_id: config.clientAppID,
	};
	this._tokenRefreshPromise = makeHTTPRequest('POST', url, data, config.jsonHeaders)
	.then(function(request) {
	var token = this._handleNewBearerToken(request);
	console.info('Refreshed bearer token', token.slice(-6));
	}.bind(this))
	.catch(function(request) {
	console.error('Failed to refresh bearer token');
	apiClient.handleError(request);
	})
	.then(function() {
	this._tokenRefreshPromise = null;
	}.bind(this));
	}
	return this._tokenRefreshPromise;
	},

[eatyourgreens]

Closed by #149.