Sugar client: fix Panoptes authentication #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missed in #135: Promise.all should take an array as an argument. I've also added better error-logging to debug Sugar client errors.
|
Marking this as draft because I'm seeing panoptes-javascript-client/lib/sugar.js Lines 25 to 27 in bfce5ae |
Instead of checking the session and token in parallel, check the token after the user has resolved.
|
Switching from |
eatyourgreens
changed the title
camallen
reviewed
May 6, 2021
camallen
reviewed
May 6, 2021
| sugarClient.authToken = token; | ||
| auth.checkBearerToken() | ||
| .then(function (token) { | ||
| sugarClient.authToken = token; |
There was a problem hiding this comment.
I believe the sugar.connect() (below) needs to be in this promise then block to ensure the connection is after the token is setup
There was a problem hiding this comment.
Good catch. I've fixed that and I'm seeing myself show up under the Active Participants heading on Talk.
Wait for auth to complete before connecting to Sugar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missed in #135:
Promise.allshould take an array as an argument. I've also added better error-logging to debug Sugar client errors.