Update Sugar client token handling #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auth._bearerToken is undefined as of 3.3.0, so pass the token to Sugar from auth.checkBearerToken(). Check the current token before each Sugar API request.
wgranger
suggested changes
Jul 9, 2020
There was a problem hiding this comment.
There's a breaking change here in the inclusion of the beforeEveryRequest mixin with the JSONAPIClient instantiation. For reference, here is where mixins are merged in the object constructor.
I tested this with npm link on this branch against a local version of PFE. I noticed a crash when visiting the "I Fancy Cats" project on staging. PFE worked well when I took out the mixin (lines 13-19 in sugar.js).
eatyourgreens
commented
Jul 9, 2020
|
Testing this, I noticed that PFE is still on |
wgranger
approved these changes
Jul 16, 2020
eatyourgreens
added a commit
that referenced
this pull request
May 6, 2021
Missed in #135: Promise.all should take an array as an argument. I've also added better error-logging to debug Sugar client errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
auth._bearerTokenis undefined as of 3.3.0, so pass the token to Sugar fromauth.checkBearerToken().Check the current token before each Sugar API request.