Preparation for release v2023.1.4 (Engine) #1286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matsduf
requested review from
mattias-p,
hannaeko,
a user,
tgreenx and
marc-vanderwal
mattias-p
approved these changes
Sep 1, 2023
|
@tgreenx, is the description of #1282 in the updated Changes file correct? Also see #1282 (comment) |
|
For the changelog, see my suggestion here: zonemaster/zonemaster#1201 (review) |
|
@mattias-p, @marc-vanderwal and @tgreenx, please (re-) review this PR, especially the updated Changes file. |
marc-vanderwal
approved these changes
Sep 5, 2023
mattias-p
approved these changes
Sep 5, 2023
tgreenx
reviewed
Sep 5, 2023
Changes
Outdated
| v4.7.3 2023-08-07 (public fix version) | ||
|
|
||
| [Fixes] | ||
| - Fixes a bug (regression) in test case BASIC01 that made tests of zones |
There was a problem hiding this comment.
Remove (regression)
Camel case test case
There was a problem hiding this comment.
@tgreenx, camel cased it would be e.g. tEst cAse.
|
For some reason I cannot make another review right now, but I just spotted that the date is wrong in the change log. |
|
Date fixed. |
matsduf
force-pushed
the
preparation-for-v2023.1.4
branch
from
fdef49f
to
a7bd003
Compare
marc-vanderwal
approved these changes
Sep 6, 2023
marc-vanderwal
approved these changes
Sep 7, 2023
tgreenx
reviewed
Sep 7, 2023
|
@tgreenx, @mattias-p, @blacksponge, @pnax, @marc-vanderwal -- please review. |
tgreenx
approved these changes
Sep 7, 2023
marc-vanderwal
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Preparation for release.
Changes
Updates files
ChangesandEngine.pm.How to test this PR
Review the changes.