-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable blacklisting for queries by NAMESERVER15 #1285
Disable blacklisting for queries by NAMESERVER15 #1285
Conversation
Some DNS operate autoritative DNS servers in environments that drop queries performed by the NAMESERVER15 test case, i.e. version.bind/CH/TXT and version.server/CH/TXT. In those setups, the name servers in question could be mistakenly deemed unresponsive, causing subsequent queries not to be attempted at all. This leads to false warnings in other test cases. This commit disables the blacklisting of name servers that do not respond to our version probes, preventing false warnings from being emitted.
@marc-vanderwal The specification of Nameserver15 is currently being updated. See zonemaster/zonemaster#1199. I propose that we wait for the implementation update and include your proposed change then. |
It depends on whether we want to include this fix in the upcoming fix release. I think it could be nice if it were; if we can’t, I can wait. |
I think we should have a broader solution instead of just fixing NAMESERVER15. If this is seen as a work-around waiting for the broader solution, it could be fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've done some quick tests and this looks good to me.
Purpose
Some DNS operate autoritative DNS servers in environments that drop queries performed by the NAMESERVER15 test case, i.e.
version.bind/CH/TXT
andversion.server/CH/TXT
.In those setups, the name servers in question could be mistakenly deemed unresponsive, causing subsequent queries not to be attempted at all. This leads to false warnings in other test cases.
This commit disables the blacklisting of name servers that do not respond to our version probes, preventing false warnings from being emitted.
Context
Fixes #1281 (or at least, the situation leading to the creation of the issue).
Changes
Disable blacklisting of name servers not responding to
version.{bind,server}/CH/TXT
queries.How to test this PR
Before:
After: