fix: Allow setting wakeup-source on composite.
#2673
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petejohanson
added
bug
|
Could you adjust the corresponding docs page while you're at it? |
Include the base `kscan.yaml` to allow settings `wakeup-source` on composite kscan devices.
petejohanson
force-pushed
the
drivers/kscan-composite-include-base-props
branch
from
a798eaf to
cb190c9
Compare
caksoylar
reviewed
Nov 25, 2024
| | --------------- | ---- | ----------------------------------------------------------------------------------------------------------------------------- | ------- | | ||
| | `rows` | int | The number of rows in the composite matrix | | | ||
| | `columns` | int | The number of columns in the composite matrix | | | ||
| | `wakeup-source` | bool | Mark this kscan instance as able to wake the keyboard. Required to keep the child kscan devices from being suspended as well. | |
There was a problem hiding this comment.
Suggested change
| | `wakeup-source` | bool | Mark this kscan instance as able to wake the keyboard. Required to keep the child kscan devices from being suspended as well. | | |
| | `wakeup-source` | bool | Mark this kscan instance as able to wake the keyboard. Required to keep the child kscan devices from being suspended as well. | | |
4 tasks
|
Closing in favor of the more complete #2682 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include the base
kscan.yamlto allow settingswakeup-sourceon composite kscan devices.PR check-list