Fix: allow kscan-composite to wake up device. #2682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
include kscan.yaml so we can set kscan-composite as a wakeup source
modify enable and disable callback to check for wakeup capabilities of composite and children
petejohanson
reviewed
Dec 4, 2024
Comment on lines
73
to
75
| if (pm_device_wakeup_is_enabled(dev) && pm_device_wakeup_is_enabled(child_cfg->child)) { | ||
| continue; | ||
| } |
There was a problem hiding this comment.
I would expect this to disable wakeup on the child device when the composite is getting disabled.
There was a problem hiding this comment.
You are correct I think: the disable function is only called when the composite is not an enabled wakeup source. In that case the children should also not be an enabled wakeup source, so they can get suspended.
4 tasks
The disable function is only called when the composite is not an enabled wakeup source. In that case the children should also not be an enabled wakeup source, so they can get suspended
petejohanson
requested changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kscan-composite driver does not respect the wakeup capabilities of its child kscans.
This branch fixes that by checking for their capabilities and whether the composite kscan is a wakeup source, before disabling them.
Relates to #2654 and #2673
PR check-list