feat(behaviors): Adding require-prior-idle-ms for combos and hold-taps

[andrewjrae]

Detaching the global-quick-tap functionality from quick-tap term, and implementing it for both combos and hold-taps under the new option require-prior-idle-ms.

This constitutes a breaking change for users keymaps in that global-quick-tap will no longer be an option. I'm not sure what the protocol is when doing such refactors, but I think it is beneficial in the long run for two reasons: This deprecates the global-quick-tap option, however it is backwards compatible in that if it is set it will copy the quick-tap-ms to the require-prior-idle-ms.

There are two reasons for these changes;

1. This functionality can be added to combos under the new unified name require-prior-idle-ms.

2. This allows users to set a lower term for the 'global-quick-tap' (now require-prior-idle-ms) functionality (typically ~100ms), and a higher term for the regular quick-tap (typically ~200ms). This means the regular quick-tap is easier to hit, while still allowing the benefits of disabling the hold-taps during fast typing.

PR Progress:

• Refactor hold-taps to support require-prior-idle-ms rather than global-quick-tap
• Add require-prior-idle-ms functionality to combos
• Update docs

[andrewjrae]

I've now pushed a change such that he old global-quick-tap option is still usable, and will simply copy the value of quick-tap-ms to min-prior-ms if set, as per @okke-formsma's suggestion on Discord. A better name for min-prior-ms has yet to be chosen however.

[caksoylar]

Wanted to drop a note saying this has been working perfectly for me for both combos and hold-taps for the last couple of months of testing. If the idea makes sense to contributors, maybe we can add docs?

[andrewjrae]

Yah I'm sorry I've let this go stale, I moved and started a new job hehe. If someone wants to write docs they can feel free to PR my branch, otherwise I should be able to get to it next week.

[okke-formsma]

code lgtm, some docs are needed before we can merge. I left a minor comment on a comment :)

[urob]

Wanted to drop a note saying this has been working perfectly for me for both combos and hold-taps for the last couple of months of testing. If the idea makes sense to contributors, maybe we can add docs?

Same here, would be great to see this merged.

[dmchmk]

hi guys, what is the current status of this merge? Looks like no one here's against it, can we expect it to be approved any time soon?

[andrewjrae]

This was on pause for a bit while we decided on better naming. Many ideas were thrown around on discord but I'm leaning towards require-prior-idle-ms for both combos and hold taps. I just need to get around to actually renaming and then a final review from @petejohanson and or @caksoylar.

[infused-kim]

I have been using this for a few months and it’s astonishing how well it works.

It makes homerow mods actually usable.

And I think this will give users a huge reason to pick zmk over qmk.

I believe zmk state of the firmware blog post is “due” soon. And it would probably be a great opportunity to advertise this feature and “Urob-style homerow mods” in it.

So, perhaps it would be a good idea to merge this before the state of the firmware post.

[andrewjrae]

Okay, renaming done, should be ready for a final review @petejohanson @caksoylar.

[caksoylar]

Thanks for the update! A few nitpicks on docs, but otherwise LGTM docs-wise.

(Not doing a "Github approval" since that should come from a non-docs maintainer.)

[petejohanson]

One minor nitpick as well, but otherwise LGTM.

[andrewjrae]

Okay, I realized my old sweep for global quick tap must have fallen short so I did a better search and caught a few more outliers. Please review the latest commit @petejohanson, I also ended up changing cradio.keymap since it was using the now deprecated global-quick-tap.

[petejohanson]

Thanks for the work on this and your patience. LGTM!