refactor(kscan): Match direct GPIO driver to matrix driver #1288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested on my BDN9 rev2, with default debounce settings, as well as with: applied, and it worked perfectly fine, no accidental duplicated presses, fast response time (subjectively). Will peek at the code another time. |
petejohanson
reviewed
May 6, 2022
| }; \ | ||
| \ | ||
| DEVICE_DT_INST_DEFINE(index, &kscan_direct_init, NULL, &kscan_direct_data_##index, \ | ||
| &kscan_direct_config_##index, APPLICATION, \ |
There was a problem hiding this comment.
Any reason you moved this to APPLICATION instead of POST_KERNEL?
There was a problem hiding this comment.
Copy/paste from the matrix driver, where it looks like it got switched from POST_KERNEL to APPLICATION in e448f2d. Do you remember why you did that there?
joelspadin
force-pushed
the
debounce-kscan-gpio-direct
branch
from
0615ad4
to
e076111
Compare
This was referenced May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrote the direct GPIO kscan driver to match the improvements made to the matrix driver in 82cb762 and f946dc6. It now uses the same debouncing system as the matrix driver.