feat(kscan_gpio_direct) Add toggle-mode #1173
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurtis-lew
force-pushed
the
toggleswitch_pr
branch
from
c642843
to
8322dc1
Compare
|
3/19/2022, 15:01pm PST
|
kurtis-lew
force-pushed
the
toggleswitch_pr
branch
3 times, most recently
from
c530d6d
to
8bb9021
Compare
kurtis-lew
force-pushed
the
toggleswitch_pr
branch
from
8bb9021
to
72422a5
Compare
|
Inspired by #722: would be nice to get this PR out before determining where best to put the documentation for this feature. Development-wise, I'm not sure what other improvements can be made. I will test these changes after rebasing them on top of #1239 to see if the improvements in USB logging will allow alphanumeric keypresses to activate immediately. |
kurtis-lew
force-pushed
the
toggleswitch_pr
branch
from
72422a5
to
7467cfd
Compare
kurtis-lew
force-pushed
the
toggleswitch_pr
branch
from
7467cfd
to
b9c9b33
Compare
|
Closing PR in light of #1288 recently being merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(kscan_gpio_direct) Add toggle switch driver
Addresses #980 by adding a boolean
toggle-modeto the direct-wire kscan that automatically sets the required pull for the input pin to remove any quiescent current.Without
toggle-mode, pins draw about 244.3uA of current. Whentoggle-modeis enabled,ACTIVE_LOWpins had a current drain of 0.0uA whileACTIVE_HIGHpins were recorded with a quiescent current of 0.2uA.