Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix refs automatically set to nullable #1397

Merged
merged 2 commits into from
Jan 31, 2023
Merged

Fix refs automatically set to nullable #1397

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
588fca7
Fix nullable of refs
momala454 Jan 20, 2023
83f4806
typo
momala454 Jan 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Processors/AugmentProperties.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ protected function augmentType(Analysis $analysis, OA\Property $property, Contex
}

// ok, so we possibly have a type or ref
if (!Generator::isDefault($property->ref) && $typeMatches[2] === '' && $property->nullable) {
if (!Generator::isDefault($property->ref) && $typeMatches[2] === '' && !Generator::isDefault($property->nullable) && $property->nullable) {
$refKey = $this->toRefKey($context, $type);
$property->oneOf = [
$schema = new OA\Schema([
Expand Down