Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix refs automatically set to nullable #1397

Merged
merged 2 commits into from
Jan 31, 2023
Merged

Fix refs automatically set to nullable #1397

merged 2 commits into from
Jan 31, 2023

Conversation

momala454
Copy link
Contributor

Fixes the issue mentioned on #1391 (comment)

@momala454
Fix nullable of refs
588fca7 
Fixes the issue mentioned on zircote#1391 (comment)
@momala454 momala454 changed the title Fix nullable of refs Fix refs automatically set to nullable Jan 20, 2023
@momala454 momala454 mentioned this pull request Jan 20, 2023
Merged
@momala454
Copy link
Contributor Author

can someone please look at my pull requests please ?

@DerManoMann DerManoMann merged commit 420e6ad into zircote:master Jan 31, 2023
@DerManoMann
Copy link
Collaborator

Thanks @momala454 and apologies for the delay.

@momala454
Copy link
Contributor Author

thanks @DerManoMann
I think the tests on #1391 should pass now

@DerManoMann
Copy link
Collaborator

thanks @DerManoMann I think the tests on #1391 should pass now

I guess you'll need to rebase your branch then?

@momala454 momala454 deleted the patch-1 branch February 9, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@momala454 @DerManoMann