Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Issues #191 #402 and #403: Add example property and remove duplicated parameters #405

Merged

Conversation

SrMouraSilva
Copy link

@SrMouraSilva SrMouraSilva commented Sep 14, 2018

Before this fix

After the fix

  • rspec_api_docs now uses swagger examples in open_api;
  • rspec_api_docs presents correctly the queries and path parameters.

Paulo Mateus Moura da Silva added 3 commits September 14, 2018 09:34
…and remove duplicated parameters (generated by the path parameter search: RspecApiDocumentation::DSL.extract_route_parameters!)
@SrMouraSilva SrMouraSilva changed the title Issues #191 #402 and #403: Add example property and remove duplicated… Fix: Issues #191 #402 and #403: Add example property and remove duplicated parameters Dec 6, 2018
@SrMouraSilva
Copy link
Author

@oestrich

@oestrich oestrich merged commit 93b7a2e into zipmark:master Dec 6, 2018
@oestrich
Copy link
Contributor

oestrich commented Dec 6, 2018

Thanks!

@SrMouraSilva SrMouraSilva deleted the issues-393-402-403-open-api-parameters branch December 6, 2018 13:51
@SrMouraSilva
Copy link
Author

Hello @oestrich, any plans to release a version with this fix? It was entered in the master, but is not yet available in ruby gems

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants