Remove leading slashes from dirname #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @rmw |
jessieay
changed the title
* When user names a resource with a leading slash, library was trying to create a directory at the root directory of the machine * Failure was at `lib/rspec_api_documentation/writers/json_writer.rb:18` (which is where dir is being made based on resource name) * This resulted in permissions errors that were hard to debug * This change strips leading slash when evaluating which dir to put docs into
oestrich
added a commit
that referenced
this pull request
Jan 17, 2015
Remove leading slashes from dirname
|
Thanks! |
SrMouraSilva
pushed a commit
to SrMouraSilva/rspec_api_documentation
that referenced
this pull request
Sep 14, 2018
…and remove duplicated parameters (generated by the path parameter search: RspecApiDocumentation::DSL.extract_route_parameters!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a directory at the root directory of the machine
lib/rspec_api_documentation/writers/json_writer.rb:18(whichis where dir is being made based on resource name)