Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a resource explanation. #196

Closed
wants to merge 1 commit into from
Closed

Added a resource explanation. #196

wants to merge 1 commit into from

Conversation

cpomerantz
Copy link

I added a way to put explanations on resources. The syntax is the same for explanations. I also modified the templates to put the explanation after the resource name. I felt like this helped to give more options for manual documentation.

@oestrich
Copy link
Contributor

This looks good, but I would like some tests for the new feature before merging. Travis is also complaining about failing specs.

@cpomerantz
Copy link
Author

Ok, I'll take a look and fix the issue with the broken tests. I'll also add some tests for the new code.

@ghost
Copy link

ghost commented Jul 22, 2015

I've incorporated your changes into my fork and added tests.

https://github.com/jramos/rspec_api_documentation

@cpomerantz
Copy link
Author

Thanks Justin, I meant to add tests for that but completely forgot.

On Jul 21, 2015, at 6:27 PM, Justin Ramos [email protected] wrote:

I've incorporated your changes into my fork and added tests.

https://github.com/jramos/rspec_api_documentation


Reply to this email directly or view it on GitHub.

@jeffutter
Copy link
Contributor

@cpomerantz @jramos Any progress on this? I would love to see this in the main repo if possible.

@oestrich
Copy link
Contributor

Closing due to age, if tests are pushed up make sure to mention me so I can look at this again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants