Add an HTTP test client #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds RspecApiDocumentation::HttpTestClient, which can be used to
test *any* website, either on your local development box or out on the
internet somewhere.
To use, just add the following line to the top of your spec:
```
let(:client) { RspecApiDocumentation::HttpTestClient.new(self, {host: 'http://base.url.of.the.site.you.want.to.test.com/'}) }
```
|
Full disclosure: There's a few outstanding nits I have with the tests (the client is fine).
|
|
Why the need for referencing the current Rspec ExampleGroup? ? |
| @@ -19,6 +19,7 @@ Gem::Specification.new do |s| | |||
| s.add_runtime_dependency "i18n", ">= 0.1.0" | |||
| s.add_runtime_dependency "mustache", ">= 0.99.4" | |||
| s.add_runtime_dependency "json", ">= 1.4.6" | |||
| s.add_runtime_dependency "faraday", ">= 0.9.0" | |||
There was a problem hiding this comment.
We should include this similar to how webmock is required.
|
Any updates on this? |
|
I merged this locally and then did some updates. Fixing my previous issue and then making it use the same StubApp as the RackTestClient. |
|
It also uses Capybara to launch the server so we're not doing a separate process. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds RspecApiDocumentation::HttpTestClient, which can be used to test any website, either on your local development box or out on the internet somewhere.
To use, just add the following line to the top of your spec: