Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaner ZIOSpecWithKafka #588

Merged
merged 2 commits into from
Jan 17, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,24 +1,12 @@
package zio.kafka

import zio.kafka.embedded.Kafka
import zio.test._
import zio.{ Task, ZIO, ZLayer }

import java.util.UUID

trait ZIOSpecWithKafka extends ZIOSpec[TestEnvironment with Kafka] {

def kafkaPrefix: String

override val bootstrap: ZLayer[Any, Any, TestEnvironment with Kafka] =
testEnvironment ++ Kafka.embedded

def randomThing(prefix: String): Task[String] =
ZIO.attempt(UUID.randomUUID()).map(uuid => s"$prefix-$uuid")

def randomTopic: Task[String] = randomThing(s"$kafkaPrefix-topic")

def randomGroup: Task[String] = randomThing(s"$kafkaPrefix-group")

def randomClient: Task[String] = randomThing(s"$kafkaPrefix-client")
}
package zio.kafka

import zio.kafka.embedded.Kafka
import zio.test._
import zio.ZLayer

trait ZIOSpecWithKafka extends ZIOSpec[TestEnvironment with Kafka] {

override val bootstrap: ZLayer[Any, Any, TestEnvironment with Kafka] =
testEnvironment ++ Kafka.embedded

}
4 changes: 2 additions & 2 deletions zio-kafka-test/src/test/scala/zio/kafka/AdminSpec.scala
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import org.apache.kafka.clients.admin.ConfigEntry.ConfigSource
import org.apache.kafka.clients.admin.{ ConfigEntry, RecordsToDelete }
import org.apache.kafka.clients.consumer.ConsumerRecord
import org.apache.kafka.common.{ Node => JNode }
import zio.kafka.{ KafkaTestUtils, ZIOSpecWithKafka }
import zio.kafka.{ KafkaTestUtils, ZIOKafkaSpec }
import zio.kafka.KafkaTestUtils._
import zio.kafka.admin.AdminClient.{
AlterConfigOp,
Expand Down Expand Up @@ -35,7 +35,7 @@ import zio.kafka.admin.resource.{ PatternType, ResourcePattern, ResourcePatternF
import java.util.UUID
import java.util.concurrent.TimeoutException

object AdminSpec extends ZIOSpecWithKafka {
object AdminSpec extends ZIOKafkaSpec {

override val kafkaPrefix: String = "adminspec"

Expand Down
4 changes: 2 additions & 2 deletions zio-kafka-test/src/test/scala/zio/kafka/ConsumerSpec.scala
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import org.apache.kafka.clients.consumer.{ ConsumerConfig, CooperativeStickyAssi
import org.apache.kafka.common.TopicPartition
import zio._
import zio.kafka.KafkaTestUtils._
import zio.kafka.ZIOSpecWithKafka
import zio.kafka.ZIOKafkaSpec
import zio.kafka.consumer.Consumer.{ AutoOffsetStrategy, OffsetRetrieval }
import zio.kafka.consumer.diagnostics.{ DiagnosticEvent, Diagnostics }
import zio.kafka.embedded.Kafka
Expand All @@ -15,7 +15,7 @@ import zio.test.Assertion._
import zio.test.TestAspect._
import zio.test._

object ConsumerSpec extends ZIOSpecWithKafka {
object ConsumerSpec extends ZIOKafkaSpec {
override val kafkaPrefix: String = "consumespec"

override def spec: Spec[TestEnvironment & Kafka, Throwable] =
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import zio.test.Assertion._
import zio.test.TestAspect.withLiveClock
import zio.test._

object ProducerSpec extends ZIOSpecWithKafka {
object ProducerSpec extends ZIOKafkaSpec {
override val kafkaPrefix: String = "producerspec"

def withConsumerInt(subscription: Subscription, settings: ConsumerSettings) =
Expand Down
19 changes: 19 additions & 0 deletions zio-kafka-test/src/test/scala/zio/kafka/ZIOKafkaSpec.scala
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
package zio.kafka

import zio.{ Task, ZIO }

import java.util.UUID

trait ZIOKafkaSpec extends ZIOSpecWithKafka {
erikvanoosten marked this conversation as resolved.
Show resolved Hide resolved

def kafkaPrefix: String

def randomThing(prefix: String): Task[String] =
ZIO.attempt(UUID.randomUUID()).map(uuid => s"$prefix-$uuid")

def randomTopic: Task[String] = randomThing(s"$kafkaPrefix-topic")

def randomGroup: Task[String] = randomThing(s"$kafkaPrefix-group")

def randomClient: Task[String] = randomThing(s"$kafkaPrefix-client")
}