Leaner ZIOSpecWithKafka #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new ZIOSpecWithKafka (from zio#528) is very useful for testing zio-kafka applications, however, it is extended with additional tools naming which are not useful for everyone. Even so, it does force you to implement `kafkaPrefix`. This PR removes the naming extensions back to the zio-kafka-test module.
guizmaii
reviewed
Jan 17, 2023
guizmaii
approved these changes
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new ZIOSpecWithKafka (from #528) is very useful for testing zio-kafka applications, however, it is extended with additional tools for naming which are not useful for everyone. Even so, it does force you to implement
kafkaPrefix. This PR moves the naming extensions back to the zio-kafka-test module.