Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

moved transaction_records_by_id methods into it #940

Merged
merged 19 commits into from
Apr 17, 2024
Merged

moved transaction_records_by_id methods into it #940

merged 19 commits into from
Apr 17, 2024

Commits on Apr 12, 2024

  1. moved transaction_records_by_id methods into it

    @fluidvanadium
    fluidvanadium committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    9b02cd0 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'labs/dev' into move_methods_to_transact… 

    …ion_records_by_id
    @fluidvanadium
    fluidvanadium committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    fcf5c46 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2024

  1. Addressed review comments: 

    Named functions and parameters for clarity
Helperized
new constructor
Added doc comments
    @fluidvanadium
    fluidvanadium committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    22110be View commit details
    Browse the repository at this point in the history

  2. clippy auto

    @fluidvanadium
    fluidvanadium committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    8531744 View commit details
    Browse the repository at this point in the history

  3. clippy p2

    @fluidvanadium
    fluidvanadium committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    2ac142a View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'labs/dev' into move_methods_to_transact… 

    …ion_records_by_id
    @fluidvanadium
    fluidvanadium committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    a755a64 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. Update zingolib/src/wallet/transactions/recording.rs 

    Co-authored-by: oscar-pepper <[email protected]>
Signed-off-by: fluidvanadium <[email protected]>
    @fluidvanadium @Oscar-Pepper
    fluidvanadium and Oscar-Pepper authored Apr 16, 2024
    Configuration menu
    Copy the full SHA
    0742046 View commit details
    Browse the repository at this point in the history

  2. Update zingolib/src/wallet/transaction_records_by_id.rs 

    Co-authored-by: oscar-pepper <[email protected]>
Signed-off-by: fluidvanadium <[email protected]>
    @fluidvanadium @Oscar-Pepper
    fluidvanadium and Oscar-Pepper authored Apr 16, 2024
    Configuration menu
    Copy the full SHA
    9e7ee48 View commit details
    Browse the repository at this point in the history

  3. Update zingolib/src/wallet/transaction_records_by_id.rs 

    Co-authored-by: oscar-pepper <[email protected]>
Signed-off-by: fluidvanadium <[email protected]>
    @fluidvanadium @Oscar-Pepper
    fluidvanadium and Oscar-Pepper authored Apr 16, 2024
    Configuration menu
    Copy the full SHA
    dbc21c0 View commit details
    Browse the repository at this point in the history

  4. Update zingolib/src/wallet/transaction_records_by_id.rs 

    Co-authored-by: oscar-pepper <[email protected]>
Signed-off-by: fluidvanadium <[email protected]>
    @fluidvanadium @Oscar-Pepper
    fluidvanadium and Oscar-Pepper authored Apr 16, 2024
    Configuration menu
    Copy the full SHA
    ae34042 View commit details
    Browse the repository at this point in the history

  5. Update zingolib/src/wallet/transaction_records_by_id.rs 

    Co-authored-by: oscar-pepper <[email protected]>
Signed-off-by: fluidvanadium <[email protected]>
    @fluidvanadium @Oscar-Pepper
    fluidvanadium and Oscar-Pepper authored Apr 16, 2024
    Configuration menu
    Copy the full SHA
    d1b18bb View commit details
    Browse the repository at this point in the history

  6. Update zingolib/src/wallet/transaction_records_by_id.rs 

    Co-authored-by: oscar-pepper <[email protected]>
Signed-off-by: fluidvanadium <[email protected]>
    @fluidvanadium @Oscar-Pepper
    fluidvanadium and Oscar-Pepper authored Apr 16, 2024
    Configuration menu
    Copy the full SHA
    2187965 View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'labs/dev' into move_methods_to_transact… 

    …ion_records_by_id
    @fluidvanadium
    fluidvanadium committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    972c3c9 View commit details
    Browse the repository at this point in the history

  8. clarified some function names. added some doc-comments. removed an ac… 

    …cessory function
    @fluidvanadium
    fluidvanadium committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    e05b6d6 View commit details
    Browse the repository at this point in the history

  9. improve doc comments

    @fluidvanadium
    fluidvanadium committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    a3af1cf View commit details
    Browse the repository at this point in the history

  10. Merge remote-tracking branch 'labs/dev' into move_methods_to_transact… 

    …ion_records_by_id
    @fluidvanadium
    fluidvanadium committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    e074767 View commit details
    Browse the repository at this point in the history

  11. even clearer doc-comment

    @fluidvanadium
    fluidvanadium committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    9861c48 View commit details
    Browse the repository at this point in the history

  12. Merge remote-tracking branch 'labs/dev' into move_methods_to_transact… 

    …ion_records_by_id
    @fluidvanadium
    fluidvanadium committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    4502e50 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. Merge remote-tracking branch 'labs/dev' into move_methods_to_transact… 

    …ion_records_by_id
    @fluidvanadium
    fluidvanadium committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    6a0c7d3 View commit details
    Browse the repository at this point in the history