Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moved transaction_records_by_id methods into it #940

Conversation

fluidvanadium
Copy link
Contributor

@fluidvanadium fluidvanadium commented Apr 12, 2024

This is a step toward implementing input source.

A number of unit tests are incoming

@fluidvanadium fluidvanadium mentioned this pull request Apr 12, 2024
zancas
zancas previously requested changes Apr 12, 2024
zingolib/src/wallet/transaction_records_by_id.rs Outdated Show resolved Hide resolved
@fluidvanadium fluidvanadium dismissed zancas’s stale review April 12, 2024 19:33

unit tests are in another PR

@fluidvanadium fluidvanadium mentioned this pull request Apr 15, 2024
Named functions and parameters for clarity
Helperized
new constructor
Added doc comments
@fluidvanadium fluidvanadium force-pushed the move_methods_to_transaction_records_by_id branch from b3c0c5e to 22110be Compare April 15, 2024 16:02
@fluidvanadium fluidvanadium force-pushed the move_methods_to_transaction_records_by_id branch from f610970 to 205898e Compare April 15, 2024 18:02
@fluidvanadium fluidvanadium force-pushed the move_methods_to_transaction_records_by_id branch from 205898e to a755a64 Compare April 15, 2024 18:03
Copy link
Contributor

@Oscar-Pepper Oscar-Pepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great, very concise and I know exactly what im reveiewing now.

I have left a bunch of small requests / suggestions.

zingolib/src/wallet/transaction_records_by_id.rs Outdated Show resolved Hide resolved
zingolib/src/wallet/transaction_records_by_id.rs Outdated Show resolved Hide resolved
zingolib/src/wallet/transaction_records_by_id.rs Outdated Show resolved Hide resolved
zingolib/src/wallet/transaction_records_by_id.rs Outdated Show resolved Hide resolved
zingolib/src/wallet/transaction_records_by_id.rs Outdated Show resolved Hide resolved
zingolib/src/wallet/transaction_records_by_id.rs Outdated Show resolved Hide resolved
zingolib/src/wallet/transaction_records_by_id.rs Outdated Show resolved Hide resolved
zingolib/src/wallet/transaction_records_by_id.rs Outdated Show resolved Hide resolved
zingolib/src/wallet/transactions/recording.rs Outdated Show resolved Hide resolved
zingolib/src/wallet/transactions/recording.rs Outdated Show resolved Hide resolved
@fluidvanadium
Copy link
Contributor Author

only changes private structs, so no changelog is needed

Copy link
Contributor

@Oscar-Pepper Oscar-Pepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

@Oscar-Pepper Oscar-Pepper merged commit b1b9f27 into zingolabs:dev Apr 17, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants