-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
moved transaction_records_by_id methods into it #940
moved transaction_records_by_id methods into it #940
Conversation
…ion_records_by_id
Named functions and parameters for clarity Helperized new constructor Added doc comments
b3c0c5e
to
22110be
Compare
f610970
to
205898e
Compare
…ion_records_by_id
205898e
to
a755a64
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is great, very concise and I know exactly what im reveiewing now.
I have left a bunch of small requests / suggestions.
Co-authored-by: oscar-pepper <[email protected]> Signed-off-by: fluidvanadium <[email protected]>
Co-authored-by: oscar-pepper <[email protected]> Signed-off-by: fluidvanadium <[email protected]>
Co-authored-by: oscar-pepper <[email protected]> Signed-off-by: fluidvanadium <[email protected]>
Co-authored-by: oscar-pepper <[email protected]> Signed-off-by: fluidvanadium <[email protected]>
Co-authored-by: oscar-pepper <[email protected]> Signed-off-by: fluidvanadium <[email protected]>
Co-authored-by: oscar-pepper <[email protected]> Signed-off-by: fluidvanadium <[email protected]>
…ion_records_by_id
only changes private structs, so no changelog is needed |
…ion_records_by_id
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great!
This is a step toward implementing input source.
A number of unit tests are incoming