Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error handle mark spent #786

Merged
merged 8 commits into from
Apr 10, 2024

Conversation

fluidvanadium
Copy link
Contributor

if mark_note_as_spent throws an error, sync will restart from the batch

a branch of spent_process_2024

@fluidvanadium fluidvanadium mentioned this pull request Jan 23, 2024
@fluidvanadium fluidvanadium marked this pull request as draft January 23, 2024 17:21
@fluidvanadium fluidvanadium marked this pull request as ready for review January 26, 2024 21:12
@fluidvanadium fluidvanadium marked this pull request as draft January 26, 2024 21:42
@fluidvanadium
Copy link
Contributor Author

this is not necessary for release

@fluidvanadium fluidvanadium marked this pull request as ready for review March 8, 2024 20:29
@fluidvanadium
Copy link
Contributor Author

post release, this should go into dev

Copy link
Contributor

@Oscar-Pepper Oscar-Pepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are still a few unwraps in this function that would be good to remove from the code but this is an improvement for sure

@fluidvanadium fluidvanadium merged commit b2997de into zingolabs:dev Apr 10, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants