Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spent process 2024 #783

Merged
merged 213 commits into from
Jan 25, 2024
Merged

Spent process 2024 #783

merged 213 commits into from
Jan 25, 2024

Conversation

fluidvanadium
Copy link
Contributor

@fluidvanadium fluidvanadium commented Jan 15, 2024 •
edited
Loading

created integration tests that track that changing the structure of zingolib does not leave old wallet files incompatible
enumerated ConfirmationStatus with doc tests
organized and tested methods of TransactionRecord
streamlined TransactionRecord and its interface to the blockchain client

@fluidvanadium
moved json dependency to workspace. todo: remove json in favour of se…
e0d1b71 
…rde_json
@fluidvanadium
Merge branch 'cleanup_height_from_transparent_note' into fluidev
69e0728
@fluidvanadium
merged Cargo.toml
50c9fa4
@fluidvanadium
Merge remote-tracking branch 'fluid/improve_zingoliberror_metadataund…
ce0ccf8 
…erflow' into fluidev
@fluidvanadium
Merge remote-tracking branch 'fluid/updatenotes_obtain_lock_once' int…
720be06 
…o fluidev
@fluidvanadium
added zingo-status
2540bf0
@fluidvanadium
added dep to Cargo.toml
ab840fa
@fluidvanadium
Merge remote-tracking branch 'labs/dev' into confenum_5
7855cdc
@fluidvanadium
added status to TransactionMetadata
b03957d
@fluidvanadium
assign status when modifying
9a95136
@fluidvanadium
save using status
9d7ecff
@fluidvanadium
replaced unconfirmed in json
6185fdc
@fluidvanadium
caught merge- incompatibility
b19f23c
@fluidvanadium
replace summaries unconfirmed with status
063856f
@fluidvanadium
use status in write
a6b8ac3
@fluidvanadium
use status in get_notes for updating
1ab1a2f
@fluidvanadium
use status in clear_expired_mempool
a60de38
@fluidvanadium
remove TransactionMetadata.unconfirmed
1faef0c
@fluidvanadium
create_modify_get_transaction_metadata uses ConfirmationStatus
8a5427b
@fluidvanadium
error uses status
fec1aac
@fluidvanadium
changed enum variant names and used Broadcast in read case
b750096
@fluidvanadium
added backwards compatibility case
7d8e594
@fluidvanadium
used status instead of block_height in write wallet. 25 remaining men…
0db2703 
…tions

1/3 runs of darkside-tests::advanced_reorg_tests reorg_changes_incoming_tx_index
FAILED on this commit.
@fluidvanadium
use is_confirmed_before_or_at in get_user_balances
5364b4a
@fluidvanadium
added sync_with_timeout and a test
b92d629
@fluidvanadium
increased chainheight
b996e6e
@fluidvanadium
upgraded and renamed test
fc89ba8
@fluidvanadium
added biased to timeout function
4fbd932
@fluidvanadium
Merge remote-tracking branch 'labs/dev' into timed_sync_interrupt_test
827e6cb
@fluidvanadium
verified balance uses status confirmed
ef47e45
Oscar-Pepper
Oscar-Pepper previously requested changes Jan 20, 2024
View reviewed changes
Copy link
Contributor

@Oscar-Pepper Oscar-Pepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

incredible PR, this kind of work is exactly what we need to make our code easily managle, readable and more stable. great job!

i have some questions / minor changes so i am requesting changes but mostly looks ready to go

zingolib/src/wallet/transactions/read_write.rs Show resolved Hide resolved
integration-tests/tests/integrations.rs Outdated Show resolved Hide resolved
integration-tests/tests/integrations.rs Show resolved Hide resolved
integration-tests/tests/integrations.rs Show resolved Hide resolved
zingo-status/src/confirmation_status.rs Show resolved Hide resolved
zingo-status/src/confirmation_status.rs Outdated Show resolved Hide resolved
zingolib/src/blaze/fetch_full_transaction.rs Show resolved Hide resolved
zingolib/src/blaze/fetch_full_transaction.rs Show resolved Hide resolved
zingolib/src/blaze/update_notes.rs Show resolved Hide resolved
zingolib/src/wallet/notes.rs Show resolved Hide resolved
@Oscar-Pepper Oscar-Pepper mentioned this pull request Jan 22, 2024
Closed
@Oscar-Pepper Oscar-Pepper self-requested a review January 23, 2024 17:53
@fluidvanadium
Copy link
Contributor Author

i dreamnt up a way to improve the wallet load tests

@fluidvanadium fluidvanadium merged commit ada69a0 into zingolabs:dev Jan 25, 2024
16 checks passed
@fluidvanadium
Copy link
Contributor Author

fixes #663

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AArnott AArnott AArnott left review comments

@zancas zancas zancas approved these changes

@AloeareV AloeareV Awaiting requested review from AloeareV

@Oscar-Pepper Oscar-Pepper Awaiting requested review from Oscar-Pepper

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fluidvanadium @zancas @AArnott @Oscar-Pepper @AloeareV