Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spent process 2024 #783

Merged
merged 213 commits into from
Jan 25, 2024
Merged
Show file tree
Hide file tree
Changes from 204 commits
Commits
Show all changes
213 commits
Select commit Hold shift + click to select a range
e0d1b71
moved json dependency to workspace. todo: remove json in favour of se…
fluidvanadium Nov 15, 2023
69e0728
Merge branch 'cleanup_height_from_transparent_note' into fluidev
fluidvanadium Nov 21, 2023
50c9fa4
merged Cargo.toml
fluidvanadium Nov 21, 2023
ce0ccf8
Merge remote-tracking branch 'fluid/improve_zingoliberror_metadataund…
fluidvanadium Nov 21, 2023
720be06
Merge remote-tracking branch 'fluid/updatenotes_obtain_lock_once' int…
fluidvanadium Nov 21, 2023
2540bf0
added zingo-status
fluidvanadium Nov 21, 2023
ab840fa
added dep to Cargo.toml
fluidvanadium Nov 22, 2023
7855cdc
Merge remote-tracking branch 'labs/dev' into confenum_5
fluidvanadium Nov 26, 2023
b03957d
added status to TransactionMetadata
fluidvanadium Nov 22, 2023
9a95136
assign status when modifying
fluidvanadium Nov 22, 2023
9d7ecff
save using status
fluidvanadium Nov 22, 2023
6185fdc
replaced unconfirmed in json
fluidvanadium Nov 22, 2023
b19f23c
caught merge- incompatibility
fluidvanadium Nov 26, 2023
063856f
replace summaries unconfirmed with status
fluidvanadium Nov 22, 2023
a6b8ac3
use status in write
fluidvanadium Nov 22, 2023
1ab1a2f
use status in get_notes for updating
fluidvanadium Nov 22, 2023
a60de38
use status in clear_expired_mempool
fluidvanadium Nov 22, 2023
1faef0c
remove TransactionMetadata.unconfirmed
fluidvanadium Nov 22, 2023
8a5427b
create_modify_get_transaction_metadata uses ConfirmationStatus
fluidvanadium Nov 22, 2023
fec1aac
error uses status
fluidvanadium Nov 22, 2023
b750096
changed enum variant names and used Broadcast in read case
fluidvanadium Nov 27, 2023
7d8e594
added backwards compatibility case
fluidvanadium Nov 27, 2023
0db2703
used status instead of block_height in write wallet. 25 remaining men…
fluidvanadium Nov 27, 2023
5364b4a
use is_confirmed_before_or_at in get_user_balances
fluidvanadium Nov 27, 2023
b92d629
added sync_with_timeout and a test
fluidvanadium Nov 27, 2023
b996e6e
increased chainheight
fluidvanadium Nov 27, 2023
fc89ba8
upgraded and renamed test
fluidvanadium Nov 27, 2023
4fbd932
added biased to timeout function
fluidvanadium Nov 27, 2023
827e6cb
Merge remote-tracking branch 'labs/dev' into timed_sync_interrupt_test
fluidvanadium Nov 27, 2023
ef47e45
verified balance uses status confirmed
fluidvanadium Nov 27, 2023
225ce33
only spendable if confirmed
fluidvanadium Nov 27, 2023
a081adb
block height coerced for valuetransfer
fluidvanadium Nov 27, 2023
46256a3
Merge remote-tracking branch 'labs/dev' into timed_sync_interrupt_test
fluidvanadium Dec 5, 2023
21d2656
Merge branch 'error_test_panic' into timed_sync_interrupt_test
fluidvanadium Dec 5, 2023
9665725
Merge branch 'error_test_panic' into timed_sync_interrupt_test
fluidvanadium Dec 5, 2023
f4f55fb
updated non_empty_frontier handling
fluidvanadium Dec 5, 2023
7d13832
updated timed_interrupt test
fluidvanadium Dec 5, 2023
1bb331f
Merge remote-tracking branch 'labs/dev' into confenum_8
fluidvanadium Dec 6, 2023
e49178d
Merge remote-tracking branch 'labs/dev' into timed_sync_interrupt_test
fluidvanadium Dec 6, 2023
7cad350
all valuetransfers use coerced get_height
fluidvanadium Dec 6, 2023
692c6b8
added broadcast_unconfirmed_after helper
fluidvanadium Dec 6, 2023
010514e
unverified balance uses broadcast_unconfirmed helper
fluidvanadium Dec 6, 2023
bf83a72
get_first_transaction_block uses coerced height
fluidvanadium Dec 6, 2023
6b10e30
fix_spent_at_height uses get_height
fluidvanadium Dec 6, 2023
5ea26d7
list transparent_notes uses get_height
fluidvanadium Dec 6, 2023
5d4582a
list orchard_notes uses get_height
fluidvanadium Dec 6, 2023
143601c
list orchard notes uses confirmed_after_or_at to verify confirmation …
fluidvanadium Dec 6, 2023
fc8e341
list sapling_notes uses get_height
fluidvanadium Dec 6, 2023
cfcc2f5
get_notes_for_updating uses is_confirmed_before_or_at
fluidvanadium Dec 6, 2023
b5765c4
get_notes_for_updating uses is_confirmed_before_or_at for sapling
fluidvanadium Dec 6, 2023
77a6967
clear_expired_mempool uses status.is_expired
fluidvanadium Dec 6, 2023
1d5e9d1
remove txns (reorg) removes confirmed_after or at and broadcast_uncon…
fluidvanadium Dec 6, 2023
1b3d62d
highest txid sanity rewrite
fluidvanadium Dec 6, 2023
1d625bf
removed TransactionMetadata.block_height
fluidvanadium Dec 6, 2023
f7a3f21
blockheight placeholder is low
fluidvanadium Dec 6, 2023
7e5d454
ignore bitmask warnings
fluidvanadium Dec 6, 2023
e3b5c46
thanx to clippy for simplified match
fluidvanadium Dec 6, 2023
437fc54
removed unused argument
fluidvanadium Dec 6, 2023
06c7d19
add_new_spent_internal takes status
fluidvanadium Dec 6, 2023
9b3718d
add_new_spent uses ConfirmationStatus
fluidvanadium Dec 6, 2023
fff7973
organized TransactionMetadataSet impl block
fluidvanadium Dec 6, 2023
9cd141a
update comment
fluidvanadium Dec 6, 2023
e24b37a
remove extra allow(clippy)
fluidvanadium Dec 6, 2023
8ace3e5
revert change to TMS field name
fluidvanadium Dec 6, 2023
c962c77
added comment
fluidvanadium Dec 6, 2023
ccce1e8
resolved merge conflict for deleted function
fluidvanadium Dec 10, 2023
2cc625c
added transactions submodule read_write
fluidvanadium Dec 10, 2023
808839b
broke transactions.rs into modules
fluidvanadium Dec 10, 2023
ae2ca1e
merged confenum_9, but did not changes to get_highest. i will unit-te…
fluidvanadium Dec 10, 2023
5ed75bf
added get_highest_txid to transaction_metadata
fluidvanadium Dec 10, 2023
dbb7a06
removed a truthidublisduous field and replaced it with a method
fluidvanadium Dec 10, 2023
7cd1a38
added a unit test for get_some_txid_from_highest
fluidvanadium Dec 10, 2023
f492e2f
renamed add_new_spent to found_spent_nullifier. this function is call…
fluidvanadium Dec 10, 2023
537d884
renamed parameters
fluidvanadium Dec 10, 2023
26e3884
fixed test. get_some_txid_from_highest_wallet_block no longer gets br…
fluidvanadium Dec 10, 2023
a61b811
brought variable names in line
fluidvanadium Dec 10, 2023
be412d2
variable names
fluidvanadium Dec 11, 2023
026c5d3
refactoring process_spent
fluidvanadium Dec 11, 2023
92c2d69
\removed process_note_spent
fluidvanadium Dec 11, 2023
5ca2e75
reforged mark_spent
fluidvanadium Dec 11, 2023
c8c9645
added NoSuchNullifierInTx error variant
fluidvanadium Dec 11, 2023
adbfb3b
added error handling to mark_note_as_spent
fluidvanadium Dec 11, 2023
2abdb0a
Merge remote-tracking branch 'labs/dev' into timed_sync_interrupt_test
fluidvanadium Dec 11, 2023
e6f9eb1
found_spent_nullifier uses ZingoLibResult
fluidvanadium Dec 11, 2023
d2d3177
merged error handler fix
fluidvanadium Dec 11, 2023
2bc395d
uses handle_or_panic to panic in debug
fluidvanadium Dec 11, 2023
2156497
merged timed_sync_interrupt_test
fluidvanadium Dec 11, 2023
1cb5a45
update test dbgs
fluidvanadium Dec 11, 2023
fc54f7f
revert error handling
fluidvanadium Dec 11, 2023
166b3ec
reverted error experiment for clippy
fluidvanadium Dec 11, 2023
61df2a5
test twiddles
fluidvanadium Dec 11, 2023
719cb53
test twiddles
fluidvanadium Dec 11, 2023
699bb82
removed test and dbg for PR
fluidvanadium Dec 11, 2023
1953aa1
removed unused parameter
fluidvanadium Dec 11, 2023
02687bc
a snarky comment
fluidvanadium Dec 11, 2023
f708023
is_broadcast is a ConfirmationStatus method
fluidvanadium Dec 11, 2023
aa9239e
scan_bundle uses status
fluidvanadium Dec 11, 2023
139fa25
scan_bundle uses status
fluidvanadium Dec 11, 2023
bd60a4b
Merge remote-tracking branch 'labs/dev' into confenum_9
fluidvanadium Dec 11, 2023
2fc4467
fixed comment
fluidvanadium Dec 11, 2023
7d3d29b
streamlined confenum
fluidvanadium Dec 11, 2023
6bbefcf
merged Cargo.toml
fluidvanadium Dec 11, 2023
cca770c
removed unnecessary json
fluidvanadium Dec 11, 2023
aa7b61c
unverified transactions have Not been confirmed more than 100 times
fluidvanadium Dec 11, 2023
fe7b7c3
merged updated confenum
fluidvanadium Dec 12, 2023
ad6df16
Merge branch 'confenum_9' into refactor_transactions
fluidvanadium Dec 12, 2023
ac359d0
remove json dep from workspace
fluidvanadium Dec 12, 2023
f9ee465
merged up
fluidvanadium Dec 12, 2023
65d5202
removed redundant check
fluidvanadium Dec 12, 2023
3c81b2e
removed redundant check
fluidvanadium Dec 12, 2023
e3b28aa
Merge branch 'refactor_transactions' into spent_process_pr
fluidvanadium Dec 13, 2023
11a3aca
merged to latest dev
fluidvanadium Jan 9, 2024
fd217a1
unignored test
fluidvanadium Jan 11, 2024
247fc3a
fixed log
fluidvanadium Jan 11, 2024
5925916
added smaller chain test
Oscar-Pepper Jan 15, 2024
bea1209
upgraded test
fluidvanadium Jan 15, 2024
2d6be9c
upgraded comments
fluidvanadium Jan 15, 2024
3bdbd31
add_new_taddr_output uses status
fluidvanadium Jan 15, 2024
f510498
improved test
fluidvanadium Jan 15, 2024
ecd0f2b
Merge branch 'spent_process_2024' into sp2024_purge_unconfirmed
fluidvanadium Jan 15, 2024
8bd92a5
rearranged status var assignment
fluidvanadium Jan 15, 2024
fdff4aa
mark_txid_utxo_spent uses confirmation_status_internally
fluidvanadium Jan 15, 2024
0f61e15
mark_txid_utxo_spent uses confirmation_status as parameter
fluidvanadium Jan 15, 2024
979bcdf
parameter name specified
fluidvanadium Jan 15, 2024
7517c6f
removed useless tuple element
fluidvanadium Jan 15, 2024
8d001b6
add_taddr_spent uses status
fluidvanadium Jan 15, 2024
57b5b9b
scan_transparent bundle uses status. tODO: replace presumming (which …
fluidvanadium Jan 15, 2024
7f44194
execute_bundlescans_internal uses status
fluidvanadium Jan 15, 2024
40fb883
scan_full_tx uses ConfirmationStatus
fluidvanadium Jan 15, 2024
191db89
WIP note refactor
fluidvanadium Jan 15, 2024
096de07
added grpc delay to trigger just before the call, changed network int…
Oscar-Pepper Jan 15, 2024
30110c1
refactored NoteInterface
fluidvanadium Jan 15, 2024
44e2933
renamed TransactionMetadata to TransactionRecord
fluidvanadium Jan 15, 2024
d08a7d2
refactored TransactionRecord into a mod
fluidvanadium Jan 15, 2024
a609dc6
refactoring TransactionMetadataSet
fluidvanadium Jan 15, 2024
9c993f3
refactored transaction_record out of data
fluidvanadium Jan 15, 2024
1d3c8af
sorted transaction_record into 3 impl blocks
fluidvanadium Jan 15, 2024
e23581e
Switch output_index to option instead of placeholder, add panic if pl…
AloeareV Jan 15, 2024
1ec447b
moved txid_from_slice into utils
fluidvanadium Jan 15, 2024
50b722f
added new pub fn to TransactionRecord
fluidvanadium Jan 15, 2024
dba8f44
use get_transparent_value_spent method
fluidvanadium Jan 15, 2024
fcd0428
turn assert into zingolib error
AloeareV Jan 15, 2024
8a23af5
add_new_note uses ConfirmationStatus
fluidvanadium Jan 15, 2024
92c5a1a
fix unused result
AloeareV Jan 15, 2024
e98b5f8
Merge remote-tracking branch 'labs/dev' into spent_process_2024
fluidvanadium Jan 15, 2024
9a958ee
fixed unit test
fluidvanadium Jan 15, 2024
aeb15df
remove documentation boilerplate
zancas Jan 15, 2024
109f8cb
run cargo update
zancas Jan 15, 2024
d147a32
start documenting zingo-status
zancas Jan 15, 2024
81d8539
boilerplate doc-tests (ChatGPT generated) showing literal use-cases
zancas Jan 15, 2024
eccc772
bread-crumb for state set
zancas Jan 15, 2024
b9c589d
whitespace cleanup
zancas Jan 15, 2024
093ebf0
note this test assumes that the code is correctgit add -p
zancas Jan 16, 2024
cb967fc
remove is_broadcast in favor of if let CS::Broad..
zancas Jan 16, 2024
c8d560d
propose removing is_broadcast
zancas Jan 16, 2024
960a19e
start adding unit-test of write
zancas Jan 16, 2024
8081891
wip
zancas Jan 16, 2024
61750fd
start unit-test framework
zancas Jan 16, 2024
8da30ee
fix use paths
zancas Jan 16, 2024
ce42b4c
progress on builder/mocks
zancas Jan 16, 2024
26ae4bd
first draft of unit-test framework.. builds
zancas Jan 16, 2024
37f8d0a
draft test showing fee and send-to-self inconsistencies
Oscar-Pepper Jan 16, 2024
57c51c9
remove ChatGPT boilerplate
zancas Jan 16, 2024
388a148
mv code into existing test_framework.rs
zancas Jan 16, 2024
9eb68a8
(for now at least) the test framework is pub(crate) and cfg(test)
zancas Jan 16, 2024
cdde5ff
draft 2 send-to-self bug test
Oscar-Pepper Jan 16, 2024
37dafa5
first draft of builder-use in test works
zancas Jan 16, 2024
c24fa61
rename note to notes
zancas Jan 16, 2024
4d22114
mv build_method macro definition
zancas Jan 16, 2024
a7441a6
explicit is better than implicit: https://zen-of-python.info/explicit…
zancas Jan 16, 2024
1c194f3
make wallet.rs more explicit, wrt notes
zancas Jan 16, 2024
954144c
make which 'note' is referenced explicit
zancas Jan 16, 2024
7677e07
migrate TransparentNote from data.rs. to notes.rs, use explicit quali…
zancas Jan 16, 2024
4ae11e1
draft 3
Oscar-Pepper Jan 16, 2024
e0e291c
Merge pull request #6 from zancas/spent_process_2024
fluidvanadium Jan 16, 2024
6ef27ba
comment clarification
fluidvanadium Jan 16, 2024
bfae961
fixed uses
fluidvanadium Jan 16, 2024
9926e38
Update zingolib/src/wallet/transaction_record.rs
fluidvanadium Jan 16, 2024
51e7e5d
use method again
fluidvanadium Jan 16, 2024
dfb1c60
fix clippy, nnmd->note
AloeareV Jan 16, 2024
554a2aa
Merge remote-tracking branch 'fluid/spent_process_2024' into spent_pr…
AloeareV Jan 16, 2024
3563ec3
update comments
fluidvanadium Jan 16, 2024
f07d6af
reverted to method use
fluidvanadium Jan 16, 2024
198e7ca
merged
fluidvanadium Jan 16, 2024
5e878fa
finished test
Oscar-Pepper Jan 16, 2024
6c5ee18
fixed balance assert
Oscar-Pepper Jan 16, 2024
1f1687e
make test slightly more concise
zancas Jan 16, 2024
7d33cb1
make test slightly more succinct
zancas Jan 16, 2024
d025391
finalised shielded note marked as change test
Oscar-Pepper Jan 17, 2024
d85630e
fix rogue l that made it into code!
Oscar-Pepper Jan 17, 2024
3dce531
added third grpc call that causes bug, commented out as test takes lo…
Oscar-Pepper Jan 17, 2024
fe4be0c
Merge branch 'dev' into spent_process_2024
zancas Jan 17, 2024
14afbcc
rm a .gitinclude
zancas Jan 17, 2024
7791edd
fix clippy and extend delay time
Oscar-Pepper Jan 17, 2024
0db74ec
Merge branch 'shielded_note_marked_as_change_test' into spent_process…
zancas Jan 17, 2024
8f633ec
Merge pull request #7 from zancas/spent_process_2024
fluidvanadium Jan 17, 2024
793224a
unignored change test
fluidvanadium Jan 18, 2024
b79f9c7
updated binary location error message
fluidvanadium Jan 18, 2024
093c394
re-ignored test
fluidvanadium Jan 18, 2024
f6b238e
git included test_binaries/bins directory
fluidvanadium Jan 18, 2024
14b4831
added unit tests to transaction_record. currently, they assume new sh…
fluidvanadium Jan 18, 2024
0836639
ignored darkside test
fluidvanadium Jan 18, 2024
f4608f4
Merge branch 'unit_test_transaction_record' into spent_process_2024
fluidvanadium Jan 18, 2024
17d6ff5
upgrade doc comments
fluidvanadium Jan 18, 2024
9d189d7
added doc comments
fluidvanadium Jan 18, 2024
191f19b
went over confirmation status, writing doc tests. found a misimplemen…
fluidvanadium Jan 18, 2024
b20c2c2
reverted reorg change and write comment
fluidvanadium Jan 19, 2024
7431afa
added v28 wallet integration test
fluidvanadium Jan 23, 2024
1ad1046
removed a comment that didnt make sense
fluidvanadium Jan 23, 2024
5774626
Merge branch 'v28_wallet_integration_test' into spent_process_2024
fluidvanadium Jan 23, 2024
c866869
removed use::*
fluidvanadium Jan 23, 2024
b303183
improved v28 wallet test with lightclient balance assertion
fluidvanadium Jan 24, 2024
61c9f84
Merge branch 'v28_wallet_integration_test' into spent_process_2024
fluidvanadium Jan 25, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,7 @@ zingocli/tests/times/*
zingocli/wallets/*
zingolib/target
zingolib/test-data/*
zingo-testutils/test_binaries
zingo-testutils/test_binaries/bins/lightwalletd
zingo-testutils/test_binaries/bins/zcash-cli
zingo-testutils/test_binaries/bins/zcashd

Loading