🌸 Marketplace: Improve ManagementComponent iconography
#2221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- #2220 The icons for `TaxeRates#index` and `Flyers#show` were the same, plus `Products#index` will conflict with `Tags#index`. So now `Products#index` is 🍰 and `Flyers#show` is :qr_code: While I was doing this, I also made the following tidyings: - ✨ `SvgComponent` has `#building_storefront` icon! - ✨ `SvgComponent` has `#qr_code` icon! - 🧹 `SvgComponent` icon-method names match Heroicon's label! - 🧹 `SvgComponent#cake` does not need a wrapping `<svg ...>` tag! - 🥗 `ManagementComponent` has every link it's supposed to - 🧹 `ManagementComponent::Spec` uses `have_link` instead of `have_css` - 🧹 `ManagementComponent` eliminates usage of `ButtonComponent` We originally added the `ButtonComponent` to inject the tailwind CSS classes in Ruby, but with the changes @anaulin made, we now can use the `.button` and `.button.--primary`/`.button.--secondary` classes. Now, when I notice the `ButtonComponent` being used, I pull it out so we can (eventually) delete it.
zspencer
changed the title
Marketplace: Improve ManagementComponent IconagraphyMarketplace: Improve ManagementComponent iconography
rosschapman
approved these changes
Feb 20, 2024
zspencer
deleted the
marketplace/products/use-different-icon-for-products
branch
zspencer
added a commit
to zinc-collective/tobias
that referenced
this pull request
Mar 25, 2024
…ective#2221) - zinc-collective#2220 The icons for `TaxeRates#index` and `Flyers#show` were the same, plus `Products#index` will conflict with `Tags#index`. So now `Products#index` is 🍰 and `Flyers#show` is :qr_code: While I was doing this, I also made the following tidyings: - ✨ `SvgComponent` has `#building_storefront` icon! - ✨ `SvgComponent` has `#qr_code` icon! - 🧹 `SvgComponent` icon-method names match Heroicon's label! - 🧹 `SvgComponent#cake` does not need a wrapping `<svg ...>` tag! - 🥗 `ManagementComponent` has every link it's supposed to - 🧹 `ManagementComponent::Spec` uses `have_link` instead of `have_css` - 🧹 `ManagementComponent` eliminates usage of `ButtonComponent` We originally added the `ButtonComponent` to inject the tailwind CSS classes in Ruby, but with the changes @anaulin made, we now can use the `.button` and `.button.--primary`/`.button.--secondary` classes. Now, when I notice the `ButtonComponent` being used, I pull it out so we can (eventually) delete it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marketplace:ManagementComponent#2220The icons for
TaxeRates#indexandFlyers#showwere the same, plusProducts#indexwill conflict withTags#index.So now
Products#indexis 🍰 andFlyers#showis :qr_code:While I was doing this, I also made the following tidyings:
SvgComponenthas#building_storefronticon!SvgComponenthas#qr_codeicon!SvgComponenticon-method names match Heroicon's label!SvgComponent#cakedoes not need a wrapping<svg ...>tag!ManagementComponenthas every link it's supposed toManagementComponent::Specuseshave_linkinstead ofhave_cssManagementComponenteliminates usage ofButtonComponentWe originally added the
ButtonComponentto inject the tailwind CSS classes in Ruby, but with the changes @anaulin made, we now can use the.buttonand.button.--primary/.button.--secondaryclasses.Now, when I notice the
ButtonComponentbeing used, I pull it out so we can (eventually) delete it.Before
After