🌸 Marketplace: ManagementComponent
#2220
Comments
zspencer
added a commit
that referenced
this issue
Feb 17, 2024
- #2220 The icons for `TaxeRates#index` and `Flyers#show` were the same, plus `Products#index` will conflict with `Tags#index`. So now `Products#index` is 🍰 and `Flyers#show` is :qr_code: While I was doing this, I also made the following tidyings: - ✨ `SvgComponent` has `#building_storefront` icon! - ✨ `SvgComponent` has `#qr_code` icon! - 🧹 `SvgComponent` icon-method names match Heroicon's label! - 🧹 `SvgComponent#cake` does not need a wrapping `<svg ...>` tag! - 🥗 `ManagementComponent` has every link it's supposed to - 🧹 `ManagementComponent::Spec` uses `have_link` instead of `have_css` - 🧹 `ManagementComponent` eliminates usage of `ButtonComponent` We originally added the `ButtonComponent` to inject the tailwind CSS classes in Ruby, but with the changes @anaulin made, we now can use the `.button` and `.button.--primary`/`.button.--secondary` classes. Now, when I notice the `ButtonComponent` being used, I pull it out so we can (eventually) delete it.
zspencer
changed the title
Marketplace: ManagementComponentMarketplace: ManagementComponent
zspencer
added a commit
that referenced
this issue
Feb 20, 2024
- #2220 The icons for `TaxeRates#index` and `Flyers#show` were the same, plus `Products#index` will conflict with `Tags#index`. So now `Products#index` is 🍰 and `Flyers#show` is :qr_code: While I was doing this, I also made the following tidyings: - ✨ `SvgComponent` has `#building_storefront` icon! - ✨ `SvgComponent` has `#qr_code` icon! - 🧹 `SvgComponent` icon-method names match Heroicon's label! - 🧹 `SvgComponent#cake` does not need a wrapping `<svg ...>` tag! - 🥗 `ManagementComponent` has every link it's supposed to - 🧹 `ManagementComponent::Spec` uses `have_link` instead of `have_css` - 🧹 `ManagementComponent` eliminates usage of `ButtonComponent` We originally added the `ButtonComponent` to inject the tailwind CSS classes in Ruby, but with the changes @anaulin made, we now can use the `.button` and `.button.--primary`/`.button.--secondary` classes. Now, when I notice the `ButtonComponent` being used, I pull it out so we can (eventually) delete it.
zspencer
added a commit
to zinc-collective/tobias
that referenced
this issue
Mar 25, 2024
…ective#2221) - zinc-collective#2220 The icons for `TaxeRates#index` and `Flyers#show` were the same, plus `Products#index` will conflict with `Tags#index`. So now `Products#index` is 🍰 and `Flyers#show` is :qr_code: While I was doing this, I also made the following tidyings: - ✨ `SvgComponent` has `#building_storefront` icon! - ✨ `SvgComponent` has `#qr_code` icon! - 🧹 `SvgComponent` icon-method names match Heroicon's label! - 🧹 `SvgComponent#cake` does not need a wrapping `<svg ...>` tag! - 🥗 `ManagementComponent` has every link it's supposed to - 🧹 `ManagementComponent::Spec` uses `have_link` instead of `have_css` - 🧹 `ManagementComponent` eliminates usage of `ButtonComponent` We originally added the `ButtonComponent` to inject the tailwind CSS classes in Ruby, but with the changes @anaulin made, we now can use the `.button` and `.button.--primary`/`.button.--secondary` classes. Now, when I notice the `ButtonComponent` being used, I pull it out so we can (eventually) delete it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Gizmo:Marketplace#831DesignLibrary#1187The text was updated successfully, but these errors were encountered: