Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🥔✨ Space: Display domain on Space#edit #1600

Merged
merged 6 commits into from
Jun 29, 2023
Merged

🥔✨ Space: Display domain on Space#edit #1600

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b6e5879
display domain on Space config
KellyAH Jun 25, 2023
80e2714
Merge branch 'main' into 1513-only-show-spaces-domain
KellyAH Jun 26, 2023
7fc3ec3
Merge branch 'main' into 1513-only-show-spaces-domain
KellyAH Jun 29, 2023
c5b6ce0
refactor display branded domain
KellyAH Jun 29, 2023
12b87c8
Merge branch 'main' into 1513-only-show-spaces-domain
KellyAH Jun 29, 2023
12a1a68
Merge branch 'main' into 1513-only-show-spaces-domain
KellyAH Jun 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions app/views/spaces/_website_settings.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,13 @@
<p class="text-sm italic"><%= t('website_settings.help_text') %></p>
</header>

<h4 class="text-base"> Domain </h4>
<% if space.branded_domain.present? %>
<p class="text-sm"><%= space.branded_domain.presence || "No Domain" %></p>
<% else %>
<p class="text-sm"> No domain </p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the if/else anymore?

<% end %>

<%= form_with model: space.location do | web_settings_form | %>
<%= web_settings_form.label :enforce_ssl do %>
<%= web_settings_form.check_box :enforce_ssl %>
Expand Down