🥔✨ Space: Display domain on Space#edit
#1600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zspencer
approved these changes
Jun 26, 2023
There was a problem hiding this comment.
Looks good! to test this you will probably want to add an expectation to the SpacesController#show tests in spec/requests/spaces_controller_request_spec
or
You could make a Space::WebsiteSettingsComponent which would be testable outside the request/response cycle (and therefore slightly easier)
| @@ -4,6 +4,13 @@ | |||
| <p class="text-sm italic"><%= t('website_settings.help_text') %></p> | |||
| </header> | |||
|
|
|||
| <h4 class="text-base"> Domain </h4> | |||
| <% if space.branded_domain.present? %> | |||
| <p class="text-sm"><%= space.branded_domain %></p> | |||
There was a problem hiding this comment.
You could put the if inside the p to reduce divergence between the branches. Also, space.branded_domain.presence || "No Domain" will evaluate to "No Domain" when space.branded_domain is nil or #empty? and the value held in space.branded_domain otherwise.
Which means you could do this!
<p class="text-sm"><%= space.branded_domain.presence || "No Domain"%></p>
zspencer
changed the title
Space config displays branded domainSpace config displays branded domain
Co-authored-by: Zee Spencer <[email protected]> Co-authored-by: Ana <[email protected]> Co-authored-by: Dalton Pruitt <[email protected]>
zspencer
approved these changes
Jun 29, 2023
| <% if space.branded_domain.present? %> | ||
| <p class="text-sm"><%= space.branded_domain.presence || "No Domain" %></p> | ||
| <% else %> | ||
| <p class="text-sm"> No domain </p> |
There was a problem hiding this comment.
Do we need the if/else anymore?
zspencer
changed the title
Space config displays branded domainSpace: Display domain on Space#edit
zspencer
changed the title
Space: Display domain on Space#editSpace: Display domain on Space#edit
zspencer
added
✨ feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SpaceDomain #1513TODO
unit test when space.branded_domain=nil (redirect issue prevents us from creating unit test for when domain is set 🥔✨Space:Membermay setDomain#1595)Domain exists
Domain is nil
