🧹 Marketplace: Move into Order::NotificationMethod
#1564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The top-level `marketplace` namespace is getting pretty cluttered, and since this relates pretty squarely to the `Order` domain, and there is already an `Order::PlacedMailer` and `Order::ReceivedMailer` it seemed like a reasonable place to put it.
anaulin
approved these changes
Jun 15, 2023
zspencer
added a commit
that referenced
this pull request
Jun 28, 2023
The top-level `marketplace` namespace is getting pretty cluttered, and since this relates pretty squarely to the `Order` domain, and there is already an `Order::PlacedMailer` and `Order::ReceivedMailer` it seemed like a reasonable place to put it.
zspencer
added a commit
that referenced
this pull request
Jun 29, 2023
- #1511 🧹 `Marketplace`: Move into `Order::NotificationMethod` (#1564) The top-level `marketplace` namespace is getting pretty cluttered, and since this relates pretty squarely to the `Order` domain, and there is already an `Order::PlacedMailer` and `Order::ReceivedMailer` it seemed like a reasonable place to put it. 🥗 Request specs for `Order::NotificationMethods`
zspencer
added a commit
that referenced
this pull request
Jun 29, 2023
- #1511 🧹 `Marketplace`: Move into `Order::NotificationMethod` (#1564) The top-level `marketplace` namespace is getting pretty cluttered, and since this relates pretty squarely to the `Order` domain, and there is already an `Order::PlacedMailer` and `Order::ReceivedMailer` it seemed like a reasonable place to put it. 🥗 Request specs for `Order::NotificationMethods`
zspencer
added a commit
that referenced
this pull request
Jun 29, 2023
- #1511 🧹 `Marketplace`: Move into `Order::NotificationMethod` (#1564) The top-level `marketplace` namespace is getting pretty cluttered, and since this relates pretty squarely to the `Order` domain, and there is already an `Order::PlacedMailer` and `Order::ReceivedMailer` it seemed like a reasonable place to put it. 🥗 Request specs for `Order::NotificationMethods`
zspencer
added a commit
that referenced
this pull request
Jul 1, 2023
- #1511 🧹 `Marketplace`: Move into `Order::NotificationMethod` (#1564) The top-level `marketplace` namespace is getting pretty cluttered, and since this relates pretty squarely to the `Order` domain, and there is already an `Order::PlacedMailer` and `Order::ReceivedMailer` it seemed like a reasonable place to put it. 🥗 Request specs for `Order::NotificationMethods`
zspencer
added a commit
that referenced
this pull request
Jul 1, 2023
- #1511 🧹 `Marketplace`: Move into `Order::NotificationMethod` (#1564) The top-level `marketplace` namespace is getting pretty cluttered, and since this relates pretty squarely to the `Order` domain, and there is already an `Order::PlacedMailer` and `Order::ReceivedMailer` it seemed like a reasonable place to put it. 🥗 Request specs for `Order::NotificationMethods` * Update app/furniture/marketplace/breadcrumbs.rb Co-authored-by: KellyAH <[email protected]> * 🧹 `Marketplace`: pull `NotificationMethod` out of `Order` Interestingly enough, to `button` method pointed out a problem with putting the `Order::NotificationMethod`, in that the *routing* to the `notification_methods` is not in the `order`; which was causing the inferred translation lookup to go squiggly. I took the hint and pulled it out of the `Order` namespace. * Alphabetize the routes --------- Co-authored-by: KellyAH <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The top-level
marketplacenamespace is getting pretty cluttered, and since this relates pretty squarely to theOrderdomain, and there is already anOrder::PlacedMailerandOrder::ReceivedMailerit seemed like a reasonable place to put it.