🥔✨ Marketplace: Managing Order::NotificationMethods
#1511
Labels
✨ feature
Reduces Client's Burden or Grants them Benefits
Comments
8 tasks
zspencer
added a commit
that referenced
this issue
Jun 15, 2023
- #1511 OK this is awkwardly named, but it is the first tiny step towards allowing us to manage multiple order notification emails without the silly comma separated value.
zspencer
added a commit
that referenced
this issue
Jun 15, 2023
- #1511 OK this is awkwardly named, but it is the first tiny step towards allowing us to manage multiple order notification emails without the silly comma separated value.
zspencer
added a commit
that referenced
this issue
Jun 15, 2023
- #1511 TODO: - [ ] Write a system spec to add, update, and then destroy an OrderNotificationMethod - [ ] Write request specs for #create, #update, #destroy, etc. - [ ] Write a Component spec?
zspencer
added a commit
that referenced
this issue
Jun 15, 2023
- #1511 OK this is awkwardly named, but it is the first tiny step towards allowing us to manage multiple order notification emails without the silly comma separated value.
zspencer
added a commit
that referenced
this issue
Jun 15, 2023
- #1511 TODO: - [ ] Write a system spec to add, update, and then destroy an OrderNotificationMethod - [ ] Write request specs for #create, #update, #destroy, etc. - [ ] Write a Component spec?
9 tasks
zspencer
added a commit
that referenced
this issue
Jun 15, 2023
- #1511 OK this is awkwardly named, but it is the first tiny step towards allowing us to manage multiple order notification emails without the silly comma separated value.
zspencer
changed the title
Marketplace: Managing Order::Notification Email AddressesMarketplace: Managing Order::NotificationMethods
zspencer
added a commit
that referenced
this issue
Jun 28, 2023
- #1511 - #1187 Co-authored-by: Kelly Hong <[email protected]>
zspencer
added a commit
that referenced
this issue
Jun 28, 2023
- #1511 - #1187 Co-authored-by: Kelly Hong <[email protected]>
zspencer
added a commit
that referenced
this issue
Jun 28, 2023
zspencer
added a commit
that referenced
this issue
Jun 29, 2023
- #1511 - #1187 Co-authored-by: Kelly Hong <[email protected]>
zspencer
added a commit
that referenced
this issue
Jun 29, 2023
- #1511 🧹 `Marketplace`: Move into `Order::NotificationMethod` (#1564) The top-level `marketplace` namespace is getting pretty cluttered, and since this relates pretty squarely to the `Order` domain, and there is already an `Order::PlacedMailer` and `Order::ReceivedMailer` it seemed like a reasonable place to put it. 🥗 Request specs for `Order::NotificationMethods`
zspencer
added a commit
that referenced
this issue
Jun 29, 2023
zspencer
added a commit
that referenced
this issue
Jun 29, 2023
- #1511 🧹 `Marketplace`: Move into `Order::NotificationMethod` (#1564) The top-level `marketplace` namespace is getting pretty cluttered, and since this relates pretty squarely to the `Order` domain, and there is already an `Order::PlacedMailer` and `Order::ReceivedMailer` it seemed like a reasonable place to put it. 🥗 Request specs for `Order::NotificationMethods`
zspencer
added a commit
that referenced
this issue
Jun 29, 2023
- #1511 🧹 `Marketplace`: Move into `Order::NotificationMethod` (#1564) The top-level `marketplace` namespace is getting pretty cluttered, and since this relates pretty squarely to the `Order` domain, and there is already an `Order::PlacedMailer` and `Order::ReceivedMailer` it seemed like a reasonable place to put it. 🥗 Request specs for `Order::NotificationMethods`
zspencer
added a commit
that referenced
this issue
Jul 1, 2023
- #1511 🧹 `Marketplace`: Move into `Order::NotificationMethod` (#1564) The top-level `marketplace` namespace is getting pretty cluttered, and since this relates pretty squarely to the `Order` domain, and there is already an `Order::PlacedMailer` and `Order::ReceivedMailer` it seemed like a reasonable place to put it. 🥗 Request specs for `Order::NotificationMethods`
zspencer
added a commit
that referenced
this issue
Jul 1, 2023
- #1511 🧹 `Marketplace`: Move into `Order::NotificationMethod` (#1564) The top-level `marketplace` namespace is getting pretty cluttered, and since this relates pretty squarely to the `Order` domain, and there is already an `Order::PlacedMailer` and `Order::ReceivedMailer` it seemed like a reasonable place to put it. 🥗 Request specs for `Order::NotificationMethods` * Update app/furniture/marketplace/breadcrumbs.rb Co-authored-by: KellyAH <[email protected]> * 🧹 `Marketplace`: pull `NotificationMethod` out of `Order` Interestingly enough, to `button` method pointed out a problem with putting the `Order::NotificationMethod`, in that the *routing* to the `notification_methods` is not in the `order`; which was causing the inferred translation lookup to go squiggly. I took the hint and pulled it out of the `Order` namespace. * Alphabetize the routes --------- Co-authored-by: KellyAH <[email protected]>
zspencer
added a commit
that referenced
this issue
Jul 6, 2023
- #1511 Now that the `Marketplace` no longer has any user modifiable attributes, I got rid of all the leftovers.
zspencer
added a commit
that referenced
this issue
Jul 6, 2023
- #1511 Now that the `Marketplace` no longer has any user modifiable attributes, I got rid of all the leftovers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Marketplace:OrderNotifications andTimeline#1331DesignLibrary#1187Right now, we require people to put in a comma separated list of email addresses that will receive a notification. This was a reasonable quick hack but we probably want something a little bit nicer.
The text was updated successfully, but these errors were encountered: