Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐞 Space: SpacesController#show works with BYODomain #1178

Merged
merged 1 commit into from
Mar 3, 2023
Merged

🐞 Space: SpacesController#show works with BYODomain #1178

merged 1 commit into from
Mar 3, 2023

Commits on Mar 3, 2023

  1. 🐞 Space: SpacesController#show works with BYODomain 

    - #74

I introduced this bug in b65a233,
basically the `SpaceController#show` was not finding by domain, so it
would give an empty page.

This also adds support for using
[`assert_select`](http://api.rubyonrails.org/classes/ActionDispatch/IntegrationTest.html)
in request specs, so long as the `subject` is a `TestResponse`.
    @zspencer
    zspencer committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    2c92252 View commit details
    Browse the repository at this point in the history