🐞 Space: SpacesController#show works with BYODomain
#1178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zspencer
force-pushed
the
spaces/byo-domains/fix-broken-show
branch
3 times, most recently
from
6deed75
to
964596e
Compare
- #74 I introduced this bug in b65a233, basically the `SpaceController#show` was not finding by domain, so it would give an empty page. This also adds support for using [`assert_select`](http://api.rubyonrails.org/classes/ActionDispatch/IntegrationTest.html) in request specs, so long as the `subject` is a `TestResponse`.
zspencer
force-pushed
the
spaces/byo-domains/fix-broken-show
branch
from
964596e
to
2c92252
Compare
|
I am going to merge this because currently, no sites work :X :X :X |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Space:Domains #74Space: Fix brokenSpacesController#newaction #1171I introduced this bug in b65a233, basically the
SpaceController#showwas not finding by domain, so it would give an empty page.This also adds support for using
assert_selectin request specs, so long as thesubjectis aTestResponse.