Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove translation_key for Tuya quirk v2 thermostat #3630

Merged

Conversation

TheJulianJES
Copy link
Collaborator

Proposed change

Removes translation_key for Tuya v2 thermostat quirk, as HA should use the default device class names for these.
Also adjusted the fallback_name (default string in auto-generated HA strings.json) to "Thermostat mode".

Additional information

See: #3625 (comment)

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

@TheJulianJES TheJulianJES added Tuya Request/PR regarding a Tuya device bugfix This PR fixes a bug labels Dec 23, 2024
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.84%. Comparing base (ca569cf) to head (132db55).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3630   +/-   ##
=======================================
  Coverage   89.84%   89.84%           
=======================================
  Files         322      322           
  Lines       10371    10371           
=======================================
  Hits         9318     9318           
  Misses       1053     1053           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheJulianJES TheJulianJES merged commit 56001dd into zigpy:dev Dec 23, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This PR fixes a bug Tuya Request/PR regarding a Tuya device
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant