Add Tuya Namron thermostat _TZE204_p3lqqy2r
#3625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheJulianJES
added
Tuya
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #3625 +/- ##
==========================================
+ Coverage 89.85% 89.89% +0.03%
==========================================
Files 321 322 +1
Lines 10374 10407 +33
==========================================
+ Hits 9322 9355 +33
Misses 1052 1052 ☔ View full report in Codecov by Sentry. |
|
|
TheJulianJES
changed the title
_TZE204_p3lqqy2r
TheJulianJES
added
needs reviewer answer
TheJulianJES
approved these changes
Dec 22, 2024
Comment on lines
+177
to
+218
| .tuya_sensor( | ||
| dp_id=120, | ||
| attribute_name="current", | ||
| type=t.int16s, | ||
| divisor=10, | ||
| device_class=SensorDeviceClass.CURRENT, | ||
| state_class=SensorStateClass.MEASUREMENT, | ||
| unit=UnitOfElectricCurrent.AMPERE, | ||
| translation_key="current", | ||
| fallback_name="Current", | ||
| ) | ||
| .tuya_sensor( | ||
| dp_id=121, | ||
| attribute_name="voltage", | ||
| type=t.int16s, | ||
| device_class=SensorDeviceClass.VOLTAGE, | ||
| state_class=SensorStateClass.MEASUREMENT, | ||
| unit=UnitOfElectricPotential.VOLT, | ||
| translation_key="voltage", | ||
| fallback_name="Voltage", | ||
| ) | ||
| .tuya_sensor( | ||
| dp_id=122, | ||
| attribute_name="power", | ||
| type=t.int16s, | ||
| device_class=SensorDeviceClass.POWER, | ||
| state_class=SensorStateClass.MEASUREMENT, | ||
| unit=UnitOfPower.WATT, | ||
| translation_key="power", | ||
| fallback_name="Power", | ||
| ) | ||
| .tuya_sensor( | ||
| dp_id=123, | ||
| attribute_name="energy", | ||
| type=t.int16s, | ||
| divisor=100, | ||
| device_class=SensorDeviceClass.ENERGY, | ||
| state_class=SensorStateClass.TOTAL, | ||
| unit=UnitOfEnergy.KILO_WATT_HOUR, | ||
| translation_key="energy", | ||
| fallback_name="Energy", | ||
| ) |
There was a problem hiding this comment.
uh, I missed this too: I think we do not want a translation_key for these, as HA will use the device_class name by default.
We should remove the translation_key for these four sensors.
EDIT: See #3630
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Adds _TZE204_p3lqqy2r
Additional information
Fixes: #2868
Closes: #3565
Checklist
pre-commitchecks pass / the code has been formatted using Black