-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduce std.Build.path; deprecate LazyPath.relative #19597
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the *std.Build owner to LazyPath so that lazy paths returned from a dependency can be used in the application without friction or footguns. closes #19313
andrewrk
added
breaking
Implementing this issue could cause existing code to no longer compile or have different behavior.
zig build system
std.Build, the build runner, `zig build` subcommand, package management
release notes
This PR should be mentioned in the release notes.
labels
Apr 10, 2024
linusg
added a commit
to linusg/bdwgc
that referenced
this pull request
Apr 14, 2024
linusg
added a commit
to linusg/bdwgc
that referenced
this pull request
Apr 14, 2024
MFAshby
added a commit
to MFAshby/zig-lsp-kit
that referenced
this pull request
May 23, 2024
MFAshby
added a commit
to MFAshby/ziggy
that referenced
this pull request
May 23, 2024
MFAshby
added a commit
to MFAshby/tree-sitter
that referenced
this pull request
May 23, 2024
MFAshby
added a commit
to MFAshby/tree-sitter
that referenced
this pull request
May 23, 2024
MFAshby
added a commit
to MFAshby/cmark-gfm
that referenced
this pull request
May 24, 2024
MFAshby
added a commit
to MFAshby/flow-syntax
that referenced
this pull request
May 24, 2024
MFAshby
added a commit
to MFAshby/zeit
that referenced
this pull request
May 24, 2024
rockorager
pushed a commit
to rockorager/zeit
that referenced
this pull request
May 24, 2024
neurocyte
pushed a commit
to neurocyte/tree-sitter
that referenced
this pull request
May 24, 2024
neurocyte
pushed a commit
to neurocyte/flow-syntax
that referenced
this pull request
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking
Implementing this issue could cause existing code to no longer compile or have different behavior.
release notes
This PR should be mentioned in the release notes.
zig build system
std.Build, the build runner, `zig build` subcommand, package management
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
*std.Build
owner to LazyPath so that lazy paths returned from a dependency can be used in the application without friction or footguns.This is technically a breaking change due to
test_runner
taking a LazyPath rather than a string but it does not do the massive breaking change yet. The breakage can happen during the 0.13.0 release cycle.closes #19313
Upgrade Guide
Source-Relative LazyPath (deprecated only)
⬇️
LazyPath.relative (deprecated only)
⬇️
Test Runner (breaking)
⬇️