Update build.zig for upstream API changes #632
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @plajjan |
ivmai
reviewed
Apr 16, 2024
ivmai
pushed a commit
that referenced
this pull request
Apr 17, 2024
PR #632 (bdwgc). Zig API has changed recently, the changes in the script are needed otherwise an error is reported in the code using Build.LazyPath(). * build.zig (Path): Remove. * build.zig (zig_min_required_version): Update to "0.12.0-dev.3610". * build.zig (build): Use b.path() instead of Path.relative() and .path assignment. * build.zig (installHeader): Remove inc_path const; use b.pathJoin() and b.path() instead of b.allocator.alloc() and fmt.bufPrint().
|
Merged. Thank you! |
|
Cool! @linusg are you using bdwgc with zig? |
|
Thanks! @plajjan yes, I use it heavily in my js engine :) |
Cool! Before it I knew only 1 JS engine using bdwgc (but written in C++) - Escargot |
|
Ahh nice! I'm pleased to hear the build.zig is useful to others (I did some of the initial work there) and it's great that we're a group of people that can help maintain this :) |
|
I used to maintain my own barebones build.zig integration (https://codeberg.org/linusg/zig-build-libgc) but it's much nicer to have it upstream and with all build options supported - thanks for doing this work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See:
Compile.installHeaderbehavior, addWriteFile.addCopyDirectoryziglang/zig#19167