Don't enable optional ARM Cortex-M series CPU features by default #18498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on the Arm Cortex-M Processor Comparison Table v3.0 <https://developer.arm.com/documentation/102787/0300/?lang=en>
release/17.x branch, commit 8f4dd44097c9ae25dd203d5ac87f3b48f854bba8 (same as the previous run)
|
Nice work, thank you! |
alexrp
added a commit
to alexrp/zig
that referenced
this pull request
Sep 24, 2024
cortex-m85 already has 8msecext, which is not the same as trustzone. The former is for the M profile, while the latter is for the A profile. Revert of a small part of ziglang#18498.
richerfu
pushed a commit
to richerfu/zig
that referenced
this pull request
Oct 28, 2024
cortex-m85 already has 8msecext, which is not the same as trustzone. The former is for the M profile, while the latter is for the A profile. Revert of a small part of ziglang#18498.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17374
Updates
update_cpu_features.zigto support omitting deps and adds overrides for incorrect ARM Cortex-M series CPU definitions, most of them optional features that should not be enabled by default.Based on the official Arm Cortex-M Processor Comparison Table. Specifically the following highlighted features were incorrect:
I then re-ran
update_cpu_features.zigusing allvm-tblgenbuilt from llvm/llvm-project@8f4dd44, the exact same revision as the last time CPU features were updated (3ed40b1).