compiler: enable caching for -femit-h #14606
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As documented in ziglang#14416, when using `zig build-lib -femit-h` with caching enabled, if the generated header file is removed, it will not be generated again, unless the library source code is modified. For consistent builds with `zig build`, assume that the file generated by -femit using the default path is an artificact, and update src/main.zig to enable caching. Update the flushEmitH function in src/link/C.zig to use the zig_cache_artifact_directory instead of the incorrect local_cache_directory. Updates ziglang#14416
|
Also, there is not test case, since I noticed that there are currently no test cases in |
3 tasks
|
This PR depends on #9698. Let's revisit this once that issue is resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As documented in #14416, when using
zig build-lib -femit-hwith caching enabled, if the generated header file is removed, it will not be generated again, unless the library source code is modified.For consistent builds with
zig build, assume that the file generated by -femit using the default path is an artificact, and update src/main.zig to enable caching.Update the flushEmitH function in src/link/C.zig to use the zig_cache_artifact_directory instead of the incorrect local_cache_directory.
Updates #14416