Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: include zig.h when CompileStep.emit_h is true #14576

Closed
wants to merge 1 commit into from

Conversation

perillo
Copy link
Contributor

@perillo perillo commented Feb 6, 2023

When linking to a library or object and emit_h is set to true, include the zig.h header file, since the generated header file will include it.

Add a standalone test case.

When linking to a library or object and emit_h is set to true, include
the zig.h header file, since the generated header file will include it.

Add a standalone test case.
@perillo
Copy link
Contributor Author

perillo commented Feb 6, 2023

This is an attempt to solve #14416.

It is a draft because the test case is currently not working (but when building manually it works).
Another problem is that the math.h file is deleted, the test will fail.

I'm also not sure what to do if zig_lib_dir is an empty string.

@andrewrk
Copy link
Member

Closing abandoned draft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants