Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inherit Datasets from LightningDataModule #46

Merged
merged 5 commits into from
Feb 1, 2021
Merged

Conversation

zhiqwang
Copy link
Owner

@zhiqwang zhiqwang commented Feb 1, 2021

This is a follow-up PR of #43 .

@zhiqwang zhiqwang added the enhancement New feature or request label Feb 1, 2021
@codecov
Copy link

codecov bot commented Feb 1, 2021

Codecov Report

Merging #46 (b29f94d) into master (3171d65) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #46   +/-   ##
=======================================
  Coverage   78.35%   78.35%           
=======================================
  Files           8        8           
  Lines         619      619           
=======================================
  Hits          485      485           
  Misses        134      134           
Flag Coverage Δ
unittests 78.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/test_engine.py 97.72% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3171d65...b29f94d. Read the comment docs.

@zhiqwang zhiqwang merged commit cc65a6d into master Feb 1, 2021
@zhiqwang zhiqwang deleted the optimize-lightning branch February 1, 2021 18:37
@zhiqwang zhiqwang added the API Library use interface label Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Library use interface enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant