Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate the trainer to Lightning #43

Merged
merged 9 commits into from
Jan 29, 2021
Merged

Migrate the trainer to Lightning #43

merged 9 commits into from
Jan 29, 2021

Conversation

zhiqwang
Copy link
Owner

Closes #34

@zhiqwang zhiqwang added the enhancement New feature or request label Jan 29, 2021
@codecov
Copy link

codecov bot commented Jan 29, 2021

Codecov Report

Merging #43 (96f5800) into master (378a5c9) will increase coverage by 7.58%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
+ Coverage   70.77%   78.35%   +7.58%     
==========================================
  Files           8        8              
  Lines         609      619      +10     
==========================================
+ Hits          431      485      +54     
+ Misses        178      134      -44     
Flag Coverage Δ
unittests 78.35% <100.00%> (+7.58%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/dataset_utils.py 100.00% <100.00%> (+100.00%) ⬆️
test/test_engine.py 97.72% <100.00%> (+0.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 378a5c9...96f5800. Read the comment docs.

@zhiqwang zhiqwang merged commit 3171d65 into master Jan 29, 2021
@zhiqwang zhiqwang deleted the lightning-support branch January 29, 2021 18:27
@zhiqwang zhiqwang added the API Library use interface label Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Library use interface enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC] Migrate the trainer to Lightning
1 participant