Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: introduction of meta attribute broke heatmaps #623

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

pfebrer
Copy link
Contributor

@pfebrer pfebrer commented Oct 2, 2023

This fixes a bug introduced in #621. I also added some extra tests.

@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (31f5dfd) 87.26% compared to head (4f40f21) 87.70%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #623      +/-   ##
==========================================
+ Coverage   87.26%   87.70%   +0.44%     
==========================================
  Files         357      360       +3     
  Lines       47732    47792      +60     
==========================================
+ Hits        41652    41918     +266     
+ Misses       6080     5874     -206     
Files Coverage Δ
src/sisl/viz/figure/figure.py 45.00% <100.00%> (+2.27%) ⬆️
src/sisl/viz/figure/matplotlib.py 37.15% <100.00%> (+19.67%) ⬆️
src/sisl/viz/plots/tests/test_bands.py 100.00% <100.00%> (ø)
src/sisl/viz/plots/tests/test_geometry.py 100.00% <100.00%> (ø)
src/sisl/viz/plots/tests/test_grid.py 100.00% <100.00%> (ø)
src/sisl/viz/plots/tests/test_pdos.py 100.00% <100.00%> (ø)
src/sisl/viz/figure/plotly.py 38.36% <66.66%> (+12.85%) ⬆️

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -0,0 +1,27 @@
import pytest

import numpy as np

Check notice

Code scanning / CodeQL

Unused import Note test

Import of 'np' is not used.

import numpy as np

import sisl

Check notice

Code scanning / CodeQL

Module is imported with 'import' and 'import from' Note test

Module 'sisl' is imported with both 'import' and 'import from'.
@zerothi zerothi merged commit deb5f1b into zerothi:main Oct 2, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants