Cleaning tutorial notebooks. #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #621 +/- ##
=======================================
Coverage 87.25% 87.26%
=======================================
Files 355 357 +2
Lines 47720 47732 +12
=======================================
+ Hits 41639 41651 +12
Misses 6081 6081
☔ View full report in Codecov by Sentry. |
|
Missing a clean of the workbook |
|
I think it makes sense to transition to the viz module. I think everything should be in that format. :) |
pfebrer
force-pushed
the
viz_data_sources
branch
from
169931a
to
f124a59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last one hehe
I added a
normalizefunction and used it to normalize sizes of atoms so that we don't need to multiply the PDOS by some strange factor to set it as atoms sizes (which is less prone to visualization bugs).The second commit changes the siesta tutorial to use sisl.viz to plot PDOS and fatbands. I don't know if you want it or you prefer to show the technical parts of doing the analysis in this tutorial. Feel free to discard that commit :)