Fix issue 486 - in correct sign of the y component of the spin moments

[nils-wittemeier]

Fix issue #486 - in correct sign of the y component of the spin moments

[zerothi]

Did you check with siesta values?

[zerothi]

I added a new commit which also fixes PDOS calculation. :)

Could you have a look?

[codecov]

Codecov Report

Merging #487 (fb96314) into main (3f11290) will not change coverage.
The diff coverage is 100.00%.

❗ Current head fb96314 differs from pull request most recent head 623ed2c. Consider uploading reports for the commit 623ed2c to get more accurate results

@@           Coverage Diff           @@
##             main     #487   +/-   ##
=======================================
  Coverage   86.92%   86.92%           
=======================================
  Files         346      346           
  Lines       44324    44324           
=======================================
  Hits        38527    38527           
  Misses       5797     5797           

Impacted Files	Coverage Δ
sisl/physics/electron.py	77.17% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[nils-wittemeier]

The commit for the PDOS calculations looks good to me.

[zerothi]

Thanks!!

Next time, please ensure you have a clean main, i.e. your main was several commits behind :)