Merge branch 'zigzag_heteroribbon'

zerothi · Nov 22, 2023 · 07721fc · 07721fc
2 parents 0c80505 + 9d9fc1d
commit 07721fc
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -19,6 +19,7 @@ we hit release version 1.0.0.
 ### Fixed
 - enabled slicing in matrix assignments, #650
 - changed `Shape.volume()` to `Shape.volume` 
+- growth direction for zigzag heteroribbons
 
 ### Changed
 - `vacuum` is now an optional parameter for all ribbon structures

diff --git a/src/sisl/geom/nanoribbon.py b/src/sisl/geom/nanoribbon.py
@@ -330,10 +330,8 @@ class _heteroribbon_section(CompositeGeometrySection):
     invert_first: bool = field(default=False, repr=False)
 
     def __post_init__(self):
-        if self.kind == "armchair":
+        if self.kind in ("armchair", "zigzag"):
             self.long_ax, self.trans_ax = 0, 1
-        elif self.kind == "zigzag":
-            self.long_ax, self.trans_ax = 1, 0
         else:
             raise ValueError("Unknown kind={kind}, must be one of zigzag or armchair")