fixed growth direction

zerothi · Nov 8, 2023 · 9d9fc1d · 9d9fc1d
1 parent 70d5187
commit 9d9fc1d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -8,6 +8,8 @@ we hit release version 1.0.0.
 
 ## [0.14.4] - YYYY-MM-DD
 
+### Fixed
+- growth direction for zigzag heteroribbons
 
 
 ## [0.14.3] - 2023-11-07

diff --git a/src/sisl/geom/nanoribbon.py b/src/sisl/geom/nanoribbon.py
@@ -237,10 +237,8 @@ class _heteroribbon_section(CompositeGeometrySection):
     invert_first: bool = field(default=False, repr=False)
 
     def __post_init__(self):
-        if self.kind == "armchair":
+        if self.kind in ("armchair", "zigzag"):
             self.long_ax, self.trans_ax = 0, 1
-        elif self.kind == "zigzag":
-            self.long_ax, self.trans_ax = 1, 0
         else:
             raise ValueError("Unknown kind={kind}, must be one of zigzag or armchair")