Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes libsodim dependency from tests #145

Merged
merged 1 commit into from
Feb 19, 2016
Merged

Removes libsodim dependency from tests #145

merged 1 commit into from
Feb 19, 2016

Conversation

djelenc
Copy link
Member

@djelenc djelenc commented Feb 19, 2016

Problem: Since libsodium/master defaulted to tweetnacl for CURVE, the use of libsodium became optional. However, Makefile of this project still links to libsodium, which breaks the build of this bindings on a machine that does not have libsodium installed.

(Moreover, it appears that the link was redundant, since building libzmq with libsodium still succeeds.)

@benjamg
Copy link
Member

benjamg commented Feb 19, 2016

Is this a timing issue in one of the tests? I don't see how this change could have caused the failure otherwise

@xaqq
Copy link
Member

xaqq commented Feb 19, 2016

unknown location(0): fatal error in "set_socket_options_tcp_only": std::runtime_error: Address already in use

I think it's indeed a timing issue.

@djelenc
Copy link
Member Author

djelenc commented Feb 19, 2016

The tests seem to be pretty sporadic: In my case, two of them failed, but when I rerun them, they both passed. However, I'm not sure this "patch" causes that, since it only concerns compiling...

benjamg added a commit that referenced this pull request Feb 19, 2016
Removes libsodim dependency from tests
@benjamg benjamg merged commit 4d28522 into zeromq:develop Feb 19, 2016
@benjamg benjamg mentioned this pull request Feb 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants